PDP-684 : Update trufflehog-scan.yml #27
Conversation
PDP-684 : Update trufflehog-scan.yml
There was a problem hiding this comment.
Pull request overview
This PR updates the TruffleHog security scanning workflow to streamline its output and reduce verbosity while maintaining essential functionality.
Changes:
- Simplified console output by removing decorative separators and reducing logging verbosity
- Removed intermediate file scanning output section
- Consolidated summary messaging to occur after output variables are set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| git diff --name-only ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} | ||
| fi | ||
| echo "========================================" | ||
| --no-update 2>/dev/null || true) |
There was a problem hiding this comment.
Redirecting stderr to /dev/null silences all errors, making debugging difficult. Consider using 2>&1 to capture errors in the output or logging them separately for troubleshooting purposes.
| --no-update 2>/dev/null || true) | |
| --no-update || true) |
| echo "verified_count=${VERIFIED_COUNT}" >> $GITHUB_OUTPUT | ||
| echo "unverified_count=${UNVERIFIED_COUNT}" >> $GITHUB_OUTPUT | ||
| echo "Scan complete: ${VERIFIED_COUNT} verified, ${UNVERIFIED_COUNT} unverified secrets found" |
There was a problem hiding this comment.
The summary message is now output after setting GITHUB_OUTPUT variables, but it will only appear in the workflow logs. Consider whether this message should be output before setting the output variables for better visibility during workflow execution, or if the current placement is intentional.
| echo "verified_count=${VERIFIED_COUNT}" >> $GITHUB_OUTPUT | |
| echo "unverified_count=${UNVERIFIED_COUNT}" >> $GITHUB_OUTPUT | |
| echo "Scan complete: ${VERIFIED_COUNT} verified, ${UNVERIFIED_COUNT} unverified secrets found" | |
| echo "Scan complete: ${VERIFIED_COUNT} verified, ${UNVERIFIED_COUNT} unverified secrets found" | |
| echo "verified_count=${VERIFIED_COUNT}" >> $GITHUB_OUTPUT | |
| echo "unverified_count=${UNVERIFIED_COUNT}" >> $GITHUB_OUTPUT |
PDP-684 : Update trufflehog-scan.yml