PDP-684: updated workflow to checkout only head commit #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TruffleHog security scanning workflow to simplify the repository checkout process by fetching only the head commit instead of the full history.
Changes:
- Simplified checkout configuration to fetch only the PR head commit with depth of 1
- Updated base commit references to use
head.sha~1instead ofbase.shafor scanning - Clarified comment about secret resolution handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| git fetch origin +refs/pull/${{ github.event.pull_request.number }}/head:refs/remotes/origin/pr-head | ||
| echo "Fetched PR #${{ github.event.pull_request.number }} head commit: ${{ github.event.pull_request.head.sha }}" | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| fetch-depth: 1 |
There was a problem hiding this comment.
Using fetch-depth: 1 with head.sha~1 as base (lines 70, 87) will fail because the parent commit won't be available in a shallow clone. Either increase fetch-depth to 2 or revert to fetching the full history to ensure the base commit is accessible for comparison.
Suggested change
| fetch-depth: 1 | |
| fetch-depth: 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDP-684: updated workflow to checkout only head commit