Skip to content

refactor(runtime-tags): reset every pass memo with its solve pass - #4523

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-persisted-pages-xh8764-main-fixes.pass-memo
Oct 24, 2026
Merged

DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-persisted-pages-xh8764-main-fixes.pass-memo

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

The reasons solve resets the memos whose answers depend on the reasons of the moment at the start of every pass, and that list of resets was kept by hand next to the loop, so a memo added later could silently miss its reset. Being per-pass is now a property of the memo's declaration: createPassMemo and createPassPathMemo register their reset when declared, and solveReasons calls resetPassMemos() once per pass. extraReaders and bindingReaders move to it and reset exactly as before, so no output changes.

🤖 Generated with Claude Code

A memo over the reasons of the moment is now declared as one
(`createPassMemo`, `createPassPathMemo`), and `solveReasons` starts all of
them afresh with one `resetPassMemos()` instead of a list of resets kept by
hand next to the loop. Main's two such memos, `extraReaders` and
`bindingReaders`, reset as before, so no output changes. A memo added later
can no longer miss its reset: the declaration registers it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2dfb78a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DylanPiercey
DylanPiercey merged commit 5c9b80a into main Oct 24, 2026
9 checks passed
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.86%. Comparing base (7b2472a) to head (2dfb78a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4523   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files         419      419           
  Lines       20906    20910    +4     
  Branches     4176     4176           
=======================================
+ Hits        19832    19836    +4     
  Misses        617      617           
  Partials      457      457           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant