Repository navigation
refactor(runtime-tags): list the analysis phases at program exit - #4524
DylanPiercey merged 1 commit into
Conversation
`finalizeReferences()` ran reference resolution, the finalizers, the whole reason solve, module registrations and id allocation, so the program visitor's exit, the one place that orders phases, showed one call for most of them. `finalizeReferences()` now ends where references settle (after the reason expressions tags add) and returns each section's intersections; the exit calls `solveReasons()`, `finalizeRegistrations()` and `allocateIds()` itself. Each read map is cleared by its last reader: expression reads after resolution, function reads after the solve. A step added later now lands visibly on one side of the solve; a finalizer that reads reasons belongs after `solveReasons()`, not among the finalizers before it. AGENTS.md and RESUMABILITY.md name the phase each fact settles in. No output change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4524 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 419 419
Lines 20910 20911 +1
Branches 4176 4176
=======================================
+ Hits 19836 19837 +1
Misses 617 617
Partials 457 457 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (2 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: making the runtime-tag analysis phases explicit at program exit. Description check The description accurately explains the refactoring, phase ordering, read-map cleanup, documentation updates, and reported absence of output changes. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
finalizeReferences()ran reference resolution, the finalizers, the whole reason solve, module registrations and id allocation, so the program visitor's exit, the one place that orders analysis phases, showed a single call for most of them. It now ends where references settle and returns each section's intersections, and the exit callssolveReasons(),finalizeRegistrations()andallocateIds()itself. A step added later lands visibly before or after the solve; a finalizer that reads reasons was the bug this boundary would have made obvious. Each read map is now cleared by its last reader, and AGENTS.md and RESUMABILITY.md name the phase each fact settles in. No output change.🤖 Generated with Claude Code