Repository navigation
docs(runtime-tags): drop effect-order claims from the branch setup release note - #4525
Conversation
…lease note Effects carry no order guarantee, only that the DOM they read is updated before they run, so the pending note no longer promises one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
| Name | Type |
|---|---|
| @marko/runtime-tags | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title names the main change: the docs(runtime-tags) release note for the branch setup change no longer states two effect-order claims. It is specific and matches the raw summary, the description, … |
| Description check | |
The description states the purpose of the change: the pending release note for branch setup (b92c3d6) promised two effect orders, and this change removes both claims. It also states that effects h… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title names the main change: the docs(runtime-tags) release note for the branch setup change no longer states two effect-order claims. It is specific and matches the raw summary, the description, and the PR objectives. It is 79 characters, a single line, and uses the conventional prefix format.
Full details: Description check
-
Explanation
The description states the purpose of the change: the pending release note for branch setup (b92c3d6) promised two effect orders, and this change removes both claims. It also states that effects have no order guarantee and that the DOM guarantee remains. This matches the changeset summary and the PR objectives.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4525 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 419 419
Lines 20911 20911
Branches 4176 4176
=======================================
Hits 19837 19837
Misses 617 617
Partials 457 457 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The pending release note for the branch setup change (
b92c3d6fcbe) promised two effect orders: a new branch's setup effects before the effects its closures queue, and a mounting template's branches' mount effects before its own. Effects carry no order guarantee; the only guarantee is that the DOM an effect reads is updated before it runs. This drops those two claims from the note before it ships; nothing else changes.🤖 Generated with Claude Code