Open
Conversation
markotron
commented
Feb 4, 2020
Comment on lines
+23
to
+51
| export function useFeedbackSet<State, Query>( | ||
| state: State, | ||
| query: (state: State) => Set<Query>, | ||
| effect: (query: Query) => Cleanup | ||
| ) { | ||
| const activeEffects = useRef<Map<Query, Cleanup>>(new Map()); | ||
|
|
||
| const newQueries = Array.from(query(state)); | ||
| const currentQueries = Array.from(activeEffects.current.keys()); | ||
| const queriesToDelete = currentQueries.filter(currentQuery => !newQueries.includes(currentQuery)); | ||
| const queriesToAdd = newQueries.filter(newQuery => !currentQueries.includes(newQuery)); | ||
|
|
||
| queriesToDelete.forEach(toDelete => { | ||
| const effectToDelete = activeEffects.current.get(toDelete) ?? unsupported("Effect must be present!"); | ||
| effectToDelete(); // Run the cleanup function. | ||
| activeEffects.current.delete(toDelete); | ||
| }); | ||
|
|
||
| queriesToAdd.forEach(toAdd => activeEffects.current.set(toAdd, effect(toAdd))) | ||
|
|
||
| // On unmount clear all the effects. | ||
| useEffect(() => { | ||
| return () => { | ||
| activeEffects.current.forEach(cleanUp => cleanUp()); | ||
| activeEffects.current.clear(); | ||
| }; | ||
| }, []) | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of Architecture requirements, Side effects, 9.
We generate a list of users: 10 rows with random numbers from 0 to 19. Numbers represent user IDs. We also have 2 buttons, TOGGLE COMPONENT, and RELOAD.
The Reload generates a new list with random IDs while Toggle component removes the component (it unmounts it).
The idea is to demonstrate multiple features:
4.1. All in-flight requests that were needed for a previous list but are not needed now, are canceled.
4.2. All in-flight requests that were needed for a previous list and are still needed should normally continue (note that they shouldn't be restarted).
4.3. New requests that were not needed before but are needed now should be started.