Added a function for sending a log message over KISS to the host.#110
Open
alligitor wants to merge 1 commit intomarkqvist:masterfrom
Open
Added a function for sending a log message over KISS to the host.#110alligitor wants to merge 1 commit intomarkqvist:masterfrom
alligitor wants to merge 1 commit intomarkqvist:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple function that uses CMD_LOG opcode for sending a string to the host.
Message has:
Log Level
Tag
Length of message
Message
It has a limit of 256 characters for the message.
Messages are not \0 terminated since there is a length field.
I do have a concern about this code but not sure if it's a problem.
The code allocates a 257 byte buffer on the stack.. It is kinda large for embedded systems. Not sure if this is acceptable.
Mark is working on a more robust/comprehensive logging system. Feel free to decline if not in line with future plans.