EncoderWriter: no longer adhere to ‘at most one write’#220
Open
mina86 wants to merge 1 commit intomarshallpierce:masterfrom
Open
EncoderWriter: no longer adhere to ‘at most one write’#220mina86 wants to merge 1 commit intomarshallpierce:masterfrom
mina86 wants to merge 1 commit intomarshallpierce:masterfrom
Conversation
mina86
changed the title
mina86
force-pushed
the
b
branch
3 times, most recently
from
26c8049 to
38882eb
Compare
The wording around Write::write method is changing with requirement that it maps to ‘at most one write’ being removed¹. With that, change EncoderWriter::write so that it flushes entire output buffer at the beginning and then proceeds to process new input. This eliminates returning Ok(0) which is effectively an error. Also, change accounting for the occupied portion of the output buffer. Rather than just having occupied length, track occupied range which means moving data to front is no longer necessary. ¹ rust-lang/rust#107200
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording around Write::write method is changing with requirement
that it maps to ‘at most one write’ being removed¹. With that, change
EncoderWriter::write so that it flushes entire output buffer at the
beginning and then proceeds to process new input. This eliminates
returning Ok(0) which is effectively an error.
Also, change accounting for the occupied portion of the output buffer.
Rather than just having occupied length, track occupied range which
means moving data to front is no longer necessary.
¹ rust-lang/rust#107200