Fix inconsistent duplicate handling across construction paths - #77
Open
extremeandy wants to merge 1 commit into
Open
Fix inconsistent duplicate handling across construction paths#77extremeandy wants to merge 1 commit into
extremeandy wants to merge 1 commit into
Conversation
Make From<Vec>, collect, extend, and insert agree on duplicate resolution for VecMap, KeyedVecSet, and VecSet. Fixes martinohmann#66
extremeandy
force-pushed
the
fix/duplicate-handling-66
branch
from
August 10, 2026 02:34
37f2207 to
7d73200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From<Vec>,collect,extend,insert, slice/array) forVecMap,KeyedVecSet, andVecSet(fixes VecMap::from(Vec) and VecSet::from(Vec) keep different duplicates than from_iter / from([..]) #66).dedup_keep_firstanddedup_keep_last_valuehelpers: maps/keyed sets keep the first key position with the last value; sets keep the first equal element and ignore later duplicates.VecSet::insert,extend, andappend, which previously used map-style replacement instead of set semantics.Closes #66.