Add opt-in support for custom string types - #306
Open
mikomikotaishi wants to merge 1 commit into
Open
Conversation
marzer
reviewed
Jul 28, 2026
| /// conversions at the API boundary only, not the underlying storage, so retrieving a value as a | ||
| /// user-defined string type makes a copy. | ||
| template <typename T> | ||
| struct string_like : std::false_type |
Owner
There was a problem hiding this comment.
Hi, thanks for the contribution. I can see the desire for this, but to be honest I'd much prefer an inferred model, as this is inline with nlohmann::json and other common libraries in this domain, where they detect 'string-likes'.
The basic principle would be to detect types that:
- have public
const char* data() constorconst char* c_str() const - have public
size_t length() const - (optionally) not implicitly convertible to
string_view(to avoid ambiguity).
These sorts of checks should be pretty trivial to write with some expression SFINAE (is_detected or similar).
Contributor
Author
There was a problem hiding this comment.
OK, I can try and look at nlohmann::json's implementation and apply it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
This PR adds support for custom string types through an opt-in
toml::string_like<T>specialisation (inheritstd::true_typeto enable), as long as it can be convertible fromstd::string/std::string_view, and can be constructed fromconst std::string&/std::string_view(alsostd::string).Is it related to an exisiting bug report or feature request?
While I haven't found any issues specifically requesting support for non-
stdstring types, I suppose #175 is a related issue. The intention is to allow custom string types to be usable with the library, however it must be opt-in (not simply inferred), to prevent things likestd::filesystem::pathfrom being detected as "string-like" (i.e.std::is_convertible_v<std::filesystem::path, std::string_view>).Pre-merge checklist
origin/master(if necessary)