Repository navigation
Workbench field UX: truthful GI evidence and exact RCB member-selection identity - #211
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Qt Workbench field-use hardening after merged Reporting/RCB #203 and GUI parity #206-#208, starting at main 76131ba.
Operator-facing correctness: enableSelected and authored RCB enable diagnostics no longer conflate requested GI with successful GI Write or a received InformationReport. Existing native bounded report lifecycle events expose actual write outcome and accepted/rejected/decode counters, which remain separate. The inspector's selected-member identity now carries the actual active RCB reference in addition to on-wire RptID/SqNum/SubSqNum/EntryID. On indexed RCB switches sharing RptID/sequence, previously highlighted member evidence cannot persist under a different RCB.
Architecture: no new protocol Read/Write, parser, socket, poller, event stream, data store or network work; unchanged native C++/Qt source authority. Updated existing Browser convergence contract to prevent regression.
Field gates remain open: matching current source Windows release package is available from Actions only after checking artifact provenance. Real IED/vendor interoperability and pixel-exact ARSAS screenshot comparison require actual hardware and corresponding reference screenshots; no unsupported acceptance claims.
Acceptance: exact-head native IED Simulator Qt build + 55-step GUI/simulator gates, Product Naming Guard and clean automated review before merge.