Repository navigation
Workbench Browser UX: readable large primary ribbon, no duplicate model chrome - #220
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea650931ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Fixed both exact-head P1 findings on |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Observed field GUI regression
Real desktop screenshot (17 Oct 2026) shows microscopic primary controls:
RibbonActionbadge was only 7–9 px, caption 8 px, icon box 27×25 and button 66×64. Group captions 7 px, endpoint controls/status 8–9 px; the large title/duplicate model sidebar compete with actionable information. This falls far short of the supplied IEDScout reference's genuine ribbon hierarchy.Fix
test_browser_ribbon_legibility.pyin Qt CI checks button hierarchy and live-operation wiring to prevent reverting to tiny icon badges.Scope
QML Browser ribbon only plus independent static guard and Qt workflow routing. No protocol/transport/RCB changes. Distinct from PR #219 (Reports hierarchy). Exact-head Qt QML smoke + rendered browser evidence, path-scoped CI and clean review are prerequisites to merge. Screenshot parity with installed Windows app remains separate visual acceptance.