Skip to content

Workbench Browser UX: readable large primary ribbon, no duplicate model chrome - #220

Merged
masarray merged 5 commits into
mainfrom
ux/workbench-ribbon-legibility-20261017
Oct 17, 2026
Merged

masarray merged 5 commits into
mainfrom
ux/workbench-ribbon-legibility-20261017

Conversation

@masarray

Copy link
Copy Markdown
Owner

Observed field GUI regression

Real desktop screenshot (17 Oct 2026) shows microscopic primary controls: RibbonAction badge was only 7–9 px, caption 8 px, icon box 27×25 and button 66×64. Group captions 7 px, endpoint controls/status 8–9 px; the large title/duplicate model sidebar compete with actionable information. This falls far short of the supplied IEDScout reference's genuine ribbon hierarchy.

Fix

  • Enlarge all Browser primary controls to 80×86, icon/badge area to 37×35 and readable 12–16 px badge text plus two-line 11 px semibold captions (including Stop active RCB, Discover IED).
  • Increase ribbon height to 112 px, adjust group widths/separators and host/endpoint typography to avoid clipping. Preserve horizontal scrolling for smaller viewports.
  • Remove redundant read-only MODEL summary chrome from right of ribbon (identity remains in Engineering Explorer) to reclaim horizontal room for actions.
  • Keep all original enabled predicates, exact MMS RCB/session operations, warnings, native service owners, and focus/hover behavior.
  • Regression gate test_browser_ribbon_legibility.py in Qt CI checks button hierarchy and live-operation wiring to prevent reverting to tiny icon badges.

Scope

QML Browser ribbon only plus independent static guard and Qt workflow routing. No protocol/transport/RCB changes. Distinct from PR #219 (Reports hierarchy). Exact-head Qt QML smoke + rendered browser evidence, path-scoped CI and clean review are prerequisites to merge. Screenshot parity with installed Windows app remains separate visual acceptance.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T03:23:34.501776Z a321d49 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea650931ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/ied_simulator/test_browser_ribbon_legibility.py Outdated
Comment thread apps/ied_simulator/qml/IedBrowserWorkspace.qml

Copy link
Copy Markdown
Owner Author

Fixed both exact-head P1 findings on a321d49653d12d7c5009b3bb3505469ef1f6b27d: new ribbon static guard now matches existing multiline session.discoverAndConnect() handler; existing Browser convergence guard now expects 112px ribbon and SERVICES width, not removed miniature 94px/MODEL chrome. Both tests run in native IED Simulator Qt workflow. Please review current exact head. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: a321d49653

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray merged commit 9cc9bf3 into main Oct 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant