Repository navigation
Conversation
…tical-type ordering
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f29e8ba2e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact current head |
|
@codex review Please re-review exact HEAD |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e26a4595b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nonical FCDA identity
|
@codex review Please review exact latest head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 825983582e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the exact latest source head |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review Retry requested for exact commit |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
P0 SSOT recovery checkpoint: https://github.com/masarray/arstack61850/blob/main/docs/WORKBENCH_SSOT_LIVE_DATA_MODEL_MASTER_HANDOFF.md DO NOT MERGE PR #230 yet. Exact HEAD |
Source reference and problem
Implemented against masarray/ARIEC61850
src/AR.Iec61850/Mms/MmsSemanticReportValueProjector.csand masarray/arsasServices/NativeIec61850Client.SemanticReporting.cs. Both require model-scoped DataSet/member identity and fail-closed structure validation. Workbench previously exposed only positionalField Non all report structures regardless of validated SCL.Native changes
BrowserReportSemanticBinding.hpp, reusing existingMmsLiveModelDocument, nativeMmsReportValueand decodedMmsDataValue. No second parser, association, control writer or GUI-time MMS decoding.stVal,q, etc) and decoded bounded values under the existing lazy report row. On any ambiguous/mismatched model, preserve truthfulField N (wire order)fallback.connectToIed()) owns the optional semantic binding. Only the latest report projects child details; history stays lightweight. No QObject cross-thread or speculative writes.ied_report_workspace_qaand static Browser convergence guard, with SCL-vs-positional provenance label in the existing QML Inspector.Deliberate boundaries
This PR establishes P0 phase 1, not full semantic parity: only flat structures with unique typed children are named. Nested/duplicate-typed/vendor-specific structures, known CDC enums without authoritative enum mapping, and unit/multiplier are not fabricated. Follow-on expands authoritative nested schema, exact enum values and metadata with the same model-owned approach.
Gate
Require exact-head IED Simulator Qt, naming, Codex review, and Windows source-matching build before a public readiness claim; installed Windows/real relay/aplikasi pembanding side-by-side remain external acceptance.