Repository navigation
Studio P0 UX: direct SMV/PTP operation without unsolicited firmware dialogs - #231
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: daa89fa406
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| offlineSettings.previewPtp = wantsRunning | ||
| if (tray.controller) | ||
| tray.controller.showMessage("Offline PTP plan only — no network packets or clock discipline.", false) | ||
| tray.controller.showMessage("PTP preview only. Connect ESP32-P4 to transmit.", false) |
There was a problem hiding this comment.
This replacement removes the exact "no network packets or clock discipline" marker still required by check_operator_workspace.py:105-107. Running that script now exits with Studio workspace contract failed: PTP/smpSynch offline controls must be plans only, not device writes, and the Qt workflow runs it unconditionally at .github/workflows/arstack-studio-qt.yml:173-175, so this commit cannot pass CI unless the existing assertion is updated or the marker is retained.
Useful? React with 👍 / 👎.
1 participant
Operator requirement
The tool must feel like a direct SMV and PTP traffic injector for relay testing, not a complex lab-only wizard. Operators should be able to configure signals, enable PTP, and Start/Stop SV; no repetitive lab warnings/automatic modal stacks.
Changes
smpSynchvalues change the transmitted flag, not physical clock synchronization.No new confirmation dialog, Start/Stop gate, hardware interlock, PTP status fabrication, forced smpSynch promotion, or change to firmware/protocol. Actual transport identity/compatible firmware checks remain because a mismatched binary cannot be safely commanded; they are not lab-mode restrictions.
CI: Qt / Windows lifecycle / Native Preview must pass, followed by operator screenshot verification. Does not convert M3 firmware experiment to stable production.