-
Notifications
You must be signed in to change notification settings - Fork 5
Jonathan/CVE #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonhilgart22
wants to merge
4
commits into
masih:main
Choose a base branch
from
pacific-ai-team:jonathan/cve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jonathan/CVE #13
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,32 @@ | ||
| module github.com/masih/fdbmeter | ||
|
|
||
| go 1.20 | ||
| go 1.25.0 | ||
|
|
||
| require ( | ||
| // Foundation DB golang binding version 7.3.7 | ||
| // See: https://github.com/apple/foundationdb/tree/7.3.7/bindings/go | ||
| github.com/apple/foundationdb/bindings/go v0.0.0-20230710184144-e3b440ca0859 | ||
| github.com/prometheus/client_golang v1.15.1 | ||
| go.opentelemetry.io/otel v1.16.0 | ||
| go.opentelemetry.io/otel/exporters/prometheus v0.39.0 | ||
| go.opentelemetry.io/otel/metric v1.16.0 | ||
| go.opentelemetry.io/otel/sdk/metric v0.39.0 | ||
| github.com/prometheus/client_golang v1.23.2 | ||
| go.opentelemetry.io/otel v1.35.0 | ||
| go.opentelemetry.io/otel/exporters/prometheus v0.57.0 | ||
| go.opentelemetry.io/otel/metric v1.35.0 | ||
| go.opentelemetry.io/otel/sdk/metric v1.35.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/cespare/xxhash/v2 v2.2.0 // indirect | ||
| github.com/go-logr/logr v1.2.4 // indirect | ||
| github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
| github.com/go-logr/logr v1.4.3 // indirect | ||
| github.com/go-logr/stdr v1.2.2 // indirect | ||
| github.com/golang/protobuf v1.5.3 // indirect | ||
| github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect | ||
| github.com/prometheus/client_model v0.4.0 // indirect | ||
| github.com/prometheus/common v0.42.0 // indirect | ||
| github.com/prometheus/procfs v0.9.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.16.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.16.0 // indirect | ||
| golang.org/x/sys v0.8.0 // indirect | ||
| google.golang.org/protobuf v1.30.0 // indirect | ||
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||
| github.com/prometheus/client_model v0.6.2 // indirect | ||
| github.com/prometheus/common v0.66.1 // indirect | ||
| github.com/prometheus/procfs v0.16.1 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.1.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.35.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.35.0 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.2 // indirect | ||
| golang.org/x/sys v0.42.0 // indirect | ||
| google.golang.org/protobuf v1.36.11 // indirect | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module Go version is now set to
go 1.25.0, but the repo’s GitHub Actions workflow still pins Go1.20.x(see.github/workflows/test.yml). With Go 1.20 the build/tests will fail because it can’t satisfy (and may not parse) agodirective this new. Update CI (and any other build tooling) to use Go >= 1.25, and consider using the canonicalgo 1.25format in go.mod to avoid version-parsing issues across tooling.