feat: Add foundation for Jira issue creation workflow by r-pedraza · Pull Request #166 · masorange/titan-cli

r-pedraza · 2026-02-24T06:53:36Z

Pull Request

📝 Summary

This PR lays the groundwork for integrating a Jira issue creation workflow. It enables the Jira plugin in the configuration and refactors the create_branch_step to use a more robust Result object pattern for handling git operations. This shift from exception-based error handling to a match/case structure improves code clarity and resilience.

🔧 Changes Made

Enabled the [plugins.jira] in .titan/config.toml.
Refactored create_branch_step.py to use ClientSuccess and ClientError result objects instead of raising GitError exceptions.
Replaced try/except blocks with match statements for handling the outcomes of all git commands (get_branches, checkout, delete_branch, create_branch).
Updated imports to use the new result types from titan_cli.core.result.

🧪 Testing

Unit tests added/updated (poetry run pytest)
All tests passing (make test)
Manual testing with titan-dev

The refactoring touches core git functionality. Existing unit tests for create_branch_step should be updated to validate the new Result-based logic, ensuring all success and error paths are handled correctly.

📊 Logs

No new log events

✅ Checklist

Self-review done
Follows the project's logging rules (no secrets, no content in logs)
New and existing tests pass
Documentation updated if needed

wiz-b6e4a6c509 · 2026-02-24T06:54:01Z

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	1
Software Management Findings	-

Total	1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

plugins/titan-plugin-jira/titan_plugin_jira/steps/ai_enhance_issue_description_step.py

.titan/config.toml

plugins/titan-plugin-jira/tests/operations/test_issue_operations.py

plugins/titan-plugin-jira/titan_plugin_jira/clients/jira_client.py

finxo · 2026-03-02T09:41:35Z

plugins/titan-plugin-jira/titan_plugin_jira/operations/issue_operations.py

+
+def find_ready_to_dev_transition(
+    jira_client: "JiraClient", issue_key: str
+) -> ClientResult["UITransition"]:


This should not return the ClientResult, just the UITransition

finxo · 2026-03-02T09:42:28Z

plugins/titan-plugin-jira/titan_plugin_jira/operations/issue_operations.py

+
+def transition_issue_to_ready_for_dev(
+    jira_client: "JiraClient", issue_key: str
+) -> ClientResult[None]:


ClientResult, should not be returned in operations. It's just to Client/Service. The step that calls this should call try/except

Already fixed. The function now returns None and raises exceptions instead of returning ClientResult[None], following the operations layer pattern.

Already resolved. Function returns UITransition (UI model) and raises exceptions, following the operations pattern correctly.

plugins/titan-plugin-jira/titan_plugin_jira/utils/input_validation.py

plugins/titan-plugin-jira/titan_plugin_jira/steps/select_issue_priority_step.py

finxo · 2026-03-02T09:45:11Z

plugins/titan-plugin-jira/titan_plugin_jira/steps/select_issue_type_step.py

+
+            selected_type = issue_types[index]
+
+            if not selected_type:


It should never be false here

finxo · 2026-03-02T09:46:51Z

plugins/titan-plugin-jira/titan_plugin_jira/steps/create_generic_issue_step.py

+    match transition_result:
+        case ClientSuccess():
+            # Get transition details to show user
+            find_result = ctx.jira.get_transitions(issue_key)


You are calling the api twice. In line 128 you have already called the api. You need to add the necessary data to the clientSuccess.message, or in the data model

finxo · 2026-03-02T10:02:07Z

plugins/titan-plugin-jira/titan_plugin_jira/utils/input_validation.py

+        value = int(selection)
+        index = value - 1
+
+        if index < 0 or index >= max_value:


You should validate min_value as well

plugins/titan-plugin-jira/titan_plugin_jira/steps/prompt_issue_description_step.py

plugins/titan-plugin-jira/titan_plugin_jira/steps/select_issue_type_step.py

finxo · 2026-03-02T10:09:25Z

plugins/titan-plugin-jira/titan_plugin_jira/steps/select_issue_priority_step.py

+    """
+    ctx.textual.begin_step(StepTitles.PRIORITY)
+
+    ctx.textual.markdown("## 🔥 Priority")


These should not be a markdown. Check the rest of the steps, cause the title of something's should not be a markdown,

finxo

Also testing the PR I found this bug:

────────────────────────────────────────────────────────────────────────────────
 SESSION START  2026-03-02 10:14:41 UTC   PID 85720
────────────────────────────────────────────────────────────────────────────────
{"version": "0.1.11", "mode": "development", "log_level": "WARNING", "pid": 85720, "log_file": "/home/alex/.local/state/titan/logs/titan.log", "event": "session_started", "level": "info", "logger": "titan", "timestamp": "2026-03-02T10:14:41.119017Z"}
{"name": "git", "event": "plugin_initialized", "level": "info", "logger": "titan_cli.core.plugins.plugin_registry", "timestamp": "2026-03-02T10:14:41.150177Z"}
{"name": "jira", "event": "plugin_initialized", "level": "info", "logger": "titan_cli.core.plugins.plugin_registry", "timestamp": "2026-03-02T10:14:41.226858Z"}
{"name": "github", "event": "plugin_initialized", "level": "info", "logger": "titan_cli.core.plugins.plugin_registry", "timestamp": "2026-03-02T10:14:41.591243Z"}
{"message": "Status retrieved", "result_type": "UIGitStatus", "duration": 0.015, "event": "get_status_success", "level": "info", "logger": "titan_plugin_git.clients.services.status_service", "timestamp": "2026-03-02T10:14:41.623199Z"}
{"message": "Status retrieved", "result_type": "UIGitStatus", "duration": 0.022, "event": "get_status_success", "level": "info", "logger": "titan_plugin_git.clients.services.status_service", "timestamp": "2026-03-02T10:14:42.668828Z"}
{"message": "Status retrieved", "result_type": "UIGitStatus", "duration": 0.021, "event": "get_status_success", "level": "info", "logger": "titan_plugin_git.clients.services.status_service", "timestamp": "2026-03-02T10:14:45.829840Z"}
{"message": "Status retrieved", "result_type": "UIGitStatus", "duration": 0.021, "event": "get_status_success", "level": "info", "logger": "titan_plugin_git.clients.services.status_service", "timestamp": "2026-03-02T10:15:00.475315Z"}
{"workflow": "Create Jira Issue", "source": "plugin", "total_steps": 7, "is_nested": false, "event": "workflow_started", "level": "info", "logger": "titan_cli.ui.tui.textual_workflow_executor", "timestamp": "2026-03-02T10:15:00.581044Z"}
{"workflow": "Create Jira Issue", "step_id": "description", "message": "Brief description captured: 87 characters", "duration": 16.898, "event": "step_success", "level": "info", "logger": "titan_cli.ui.tui.textual_workflow_executor", "timestamp": "2026-03-02T10:15:17.485003Z"}
{"message": "Found 21 issue types", "result_type": "list", "duration": 0.164, "event": "get_issue_types_success", "level": "info", "logger": "titan_plugin_jira.clients.services.metadata_service", "timestamp": "2026-03-02T10:15:17.657802Z"}
{"workflow": "Create Jira Issue", "step_id": "issue_type", "message": "Issue type selected: Epic", "duration": 13.333, "event": "step_success", "level": "info", "logger": "titan_cli.ui.tui.textual_workflow_executor", "timestamp": "2026-03-02T10:15:30.846453Z"}
{"workflow": "Create Jira Issue", "step_id": "priority", "message": "Priority selected: Highest", "duration": 10.62, "event": "step_success", "level": "info", "logger": "titan_cli.ui.tui.textual_workflow_executor", "timestamp": "2026-03-02T10:15:41.478548Z"}
{"event": "HTTP Request: POST https://llm.tools.cloud.masorange.es/v1/messages \"HTTP/1.1 200 OK\"", "timestamp": "2026-03-02T10:15:58.747430Z"}
{"workflow": "Create Jira Issue", "step_id": "generate_with_ai", "error": "Error executing step 'ai_enhance_issue_description' from plugin 'jira': object of type 'NoneType' has no len()", "on_error": "fail", "duration": 17.276, "event": "step_failed", "level": "error", "logger": "titan_cli.ui.tui.textual_workflow_executor", "timestamp": "2026-03-02T10:15:58.755240Z"}
{"workflow": "Create Jira Issue", "failed_at_step": "generate_with_ai", "error": "Error executing step 'ai_enhance_issue_description' from plugin 'jira': object of type 'NoneType' has no len()", "steps_completed": 4, "duration": 58.186, "event": "workflow_failed", "level": "error", "logger": "titan_cli.ui.tui.textual_workflow_executor", "timestamp": "2026-03-02T10:15:58.761589Z"}

● Encontré el bug. La cadena del problema:                                                                                                                                                                                         
                             
  1. _parse_ai_response inicializa "title": ""                                                                                                                                                                                     
  2. En el cleanup final: si queda vacío, lo pone a None → sections["title"] = None                                                                                                                                                
  3. parsed.pop("title", DEFAULT_TITLE) devuelve None (la clave existe pero vale None — el default solo aplica si la clave no existe)                                                                                              
  4. len(None) → TypeError

By: finxo

r-pedraza · 2026-03-19T09:39:07Z

finxo · 2026-03-24T07:46:10Z

plugins/titan-plugin-git/titan_plugin_git/steps/create_branch_step.py

        )

    except Exception as e:
+        import traceback


imports goes up in the file not here

finxo · 2026-03-24T07:46:33Z

plugins/titan-plugin-jira/docs/custom-templates.md

@@ -0,0 +1,167 @@
+# Plantillas Personalizadas para Issues


Never add docs in spanish

finxo · 2026-03-24T07:48:19Z

plugins/titan-plugin-jira/tests/operations/test_issue_operations.py

+        result = transition_issue_to_ready_for_dev(mock_client, "TEST-123")
+
+        # Assert
+        assert result is None


The function transition_issue_to_ready_to_dev returns UIJiraTransition not none. This is wrong test

finxo · 2026-03-24T07:48:42Z

plugins/titan-plugin-jira/tests/operations/test_issue_operations.py

+        result = transition_issue_to_ready_for_dev(mock_client, "TEST-123")
+
+        # Assert
+        assert result is None


The function transition_issue_to_ready_to_dev returns UIJiraTransition not none. This is wrong test

finxo · 2026-03-24T07:49:52Z

plugins/titan-plugin-jira/titan_plugin_jira/clients/services/issue_service.py

                error_code="CREATE_SUBTASK_ERROR"
            )

+    # ==================== INTERNAL HELPERS ====================


Remove this kind of comments

finxo · 2026-03-24T07:56:45Z

plugins/titan-plugin-jira/titan_plugin_jira/operations/issue_operations.py

+
+
+def find_ready_to_dev_transition(
+    jira_client: "JiraClient", issue_key: str


this is the problem of type_checking, you are returning a string not a class. SAme in the rest of the file

finxo · 2026-03-24T07:57:37Z

plugins/titan-plugin-jira/titan_plugin_jira/steps/ai_enhance_issue_description_step.py

+    # Call AI
+    with ctx.textual.loading("Generating description with AI..."):
+        try:
+            from titan_cli.ai.models import AIMessage


imports goes up in the file

finxo · 2026-03-24T08:00:02Z

plugins/titan-plugin-jira/titan_plugin_jira/constants.py

+Centralized to avoid hardcoding and enable easy i18n in the future.
+"""
+
+# ==================== Step Titles ====================


Avoid this kind of comments

finxo · 2026-03-24T08:00:21Z

plugins/titan-plugin-jira/titan_plugin_jira/plugin.py

        from .steps.ai_analyze_issue_step import ai_analyze_issue_requirements_step
        from .steps.list_versions_step import list_versions_step
+
+        # Technical Specification Workflow steps (COMMENTED - steps don't exist)


If this does not exist remove them

finxo · 2026-03-24T08:00:41Z

plugins/titan-plugin-jira/titan_plugin_jira/plugin.py

            "ai_analyze_issue_requirements": ai_analyze_issue_requirements_step,
            "list_versions": list_versions_step,
+
+            # Technical Specification Workflow steps (COMMENTED - steps don't exist)


If this steps does not exist remove them

finxo · 2026-03-24T08:02:31Z

plugins/titan-plugin-jira/titan_plugin_jira/clients/jira_client.py

This should return a UIModel not Network one

finxo · 2026-03-24T08:03:00Z

plugins/titan-plugin-jira/titan_plugin_jira/clients/jira_client.py

This should return a UIModel not a dict

finxo · 2026-03-24T08:03:33Z

plugins/titan-plugin-jira/titan_plugin_jira/clients/jira_client.py

This should return an UI Model not dict

finxo · 2026-03-24T08:04:01Z

plugins/titan-plugin-jira/titan_plugin_jira/clients/jira_client.py

This should return a UIModel not List[dict]

By: finxo

r-pedraza · 2026-03-24T18:43:21Z

r-pedraza · 2026-03-24T18:43:21Z

finxo · 2026-03-25T15:03:46Z

plugins/titan-plugin-jira/titan_plugin_jira/clients/jira_client.py

-            priority=priority
-        )
+        # Find issue type (delegated to operation)
+        issue_type_result = find_issue_type_by_name(self, project_key, issue_type)


Client is calling an operation and passing itself as a parameter. This is backwards - operations should call the client, not vice versa. This violates the 5-layer architecture where Client (layer 3) should never call Operations (layer 2).

finxo · 2026-03-25T15:03:46Z

plugins/titan-plugin-jira/titan_plugin_jira/clients/jira_client.py

-            description=description
-        )
+        # Find subtask issue type (delegated to operation)
+        subtask_result = find_subtask_issue_type(self, self.project_key)


Client is calling an operation and passing itself as a parameter. This is backwards - operations should call the client, not vice versa. This violates the 5-layer architecture where Client (layer 3) should never call Operations (layer 2).

finxo · 2026-03-25T15:03:46Z

plugins/titan-plugin-git/titan_plugin_git/steps/create_branch_step.py

        )

    except Exception as e:
+        import traceback


imports go up in the file, not in the exception handler. Move this to the top of the file with other imports.

feat: create jira issue workflow

d904a8b

r-pedraza self-assigned this Feb 24, 2026

wiz-b6e4a6c509 bot reviewed Feb 24, 2026

View reviewed changes

plugins/titan-plugin-jira/titan_plugin_jira/steps/ai_enhance_issue_description_step.py Show resolved Hide resolved

finxo requested changes Mar 2, 2026

View reviewed changes

finxo reviewed Mar 2, 2026

View reviewed changes

r-pedraza added 11 commits March 18, 2026 15:58

Fix: test_issue_operations.py

7b9cafb

By: finxo

Fix: jira_client.py

5444d51

By: finxo

Fix: issue_operations.py

35475c5

By: finxo

Fix: input_validation.py

fb6a2cc

By: finxo

Fix: select_issue_priority_step.py

dfb91ea

By: finxo

Fix: select_issue_type_step.py

43b4468

By: finxo

Fix: create_generic_issue_step.py

eb94498

By: finxo

Fix: input_validation.py

4755538

By: finxo

Fix: prompt_issue_description_step.py

e671fc0

By: finxo

Fix: select_issue_type_step.py

d973713

By: finxo

Fix: select_issue_priority_step.py

24a5d4c

By: finxo

r-pedraza requested a review from finxo March 19, 2026 09:40

finxo requested changes Mar 24, 2026

View reviewed changes

r-pedraza added 3 commits March 24, 2026 09:47

Fix: config.toml

9db65a4

By: finxo

Fix: jira_client.py

0fcbaf1

By: finxo

Fix: issue_operations.py

8c43a6d

By: finxo

r-pedraza requested a review from finxo March 24, 2026 18:43

finxo requested changes Mar 25, 2026

View reviewed changes

Merge branch 'master' into feat/crerate-issue-jira-core

3fbff32

fix: Return class not a String

f3bef1c



		def find_ready_to_dev_transition(
		jira_client: "JiraClient", issue_key: str

Conversation

r-pedraza commented Feb 24, 2026

Pull Request

📝 Summary

🔧 Changes Made

🧪 Testing

📊 Logs

✅ Checklist

Uh oh!

wiz-b6e4a6c509 bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Wiz Scan Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

finxo left a comment

Choose a reason for hiding this comment

Uh oh!

r-pedraza commented Mar 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wiz-b6e4a6c509 bot commented Feb 24, 2026 •

edited

Loading