Skip to content

fix: use runes instead of codeUnits in AhoCorasick search#34

Closed
Deepak8858 wants to merge 2 commits into
master-wayne7:mainfrom
Deepak8858:fix/issue-31-unicode-match
Closed

fix: use runes instead of codeUnits in AhoCorasick search#34
Deepak8858 wants to merge 2 commits into
master-wayne7:mainfrom
Deepak8858:fix/issue-31-unicode-match

Conversation

@Deepak8858

Copy link
Copy Markdown

The AhoCorasick search was using while the trie was built using . This caused matching to fail for emoji and other characters outside the Basic Multilingual Plane (BMP). This PR fixes the issue by using in the search loop as well.

Closes #31

@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68b9b518-c7d3-4ae6-9a03-2e1e0634bf6f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@master-wayne7

Copy link
Copy Markdown
Owner

@Deepak8858 I am closing this PR since it s a duplicate of #33 and also please don't target main branch, always create a PR to develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants