fix: use runes instead of codeUnits in AhoCorasick search#34
fix: use runes instead of codeUnits in AhoCorasick search#34Deepak8858 wants to merge 2 commits into
Conversation
…emoji and multi-byte characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Deepak8858 I am closing this PR since it s a duplicate of #33 and also please don't target |
The AhoCorasick search was using while the trie was built using . This caused matching to fail for emoji and other characters outside the Basic Multilingual Plane (BMP). This PR fixes the issue by using in the search loop as well.
Closes #31