Skip to content

Add sorted_variables for mutable and immutable collections#3466

Open
OldiLo wants to merge 2 commits intomate-academy:masterfrom
OldiLo:master
Open

Add sorted_variables for mutable and immutable collections#3466
OldiLo wants to merge 2 commits intomate-academy:masterfrom
OldiLo:master

Conversation

@OldiLo
Copy link
Copy Markdown

@OldiLo OldiLo commented Apr 20, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because one of the tests is still failing due to a leftover template comment, even though your sorted_variables implementation itself is correct. In app/main.py, on the first line you still have the comment # write your code here, and the test test_removed_comment explicitly checks that this starter comment has been removed from the file. This violates the task requirement that the original placeholder comment must not appear in the final solution, so it is considered a blocking issue. To fix this, delete that entire line and make sure the exact phrase # write your code here does not appear anywhere else in app/main.py (including in comments or docstrings). After removing it, run pytest again to confirm that all tests pass. Aside from this comment-removal requirement, your grouping of variables into the "mutable" and "immutable" lists is correct, so once you clean up the placeholder comment your solution should be fully acceptable.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it correctly defines the sorted_variables dictionary in app/main.py with exactly the two required keys: "mutable" and "immutable". The lists under each key properly group the existing eight variables by mutability, placing the list, dictionary, and set in "mutable", and the booleans, string, numbers, and tuple in "immutable", which matches the task requirements. You also used the originally defined variables directly rather than recreating values, which is an important part of the specification. The starter placeholder comment has been removed, and there are no functional or structural issues that would block task completion. As a minor optional improvement, you could add a short comment explaining why each type is considered mutable or immutable to reinforce the concept for future readers, but this is not required for correctness.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants