fix(button): clean up form label activation logic#5895
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
fix(button): clean up form label activation logic#5895copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
These helpers and methods are no longer needed for Firefox or Safari, and button does not add click listeners to inner elements that require dispatching the activation click on the inner button. Tested locally with Chrome, Firefox, and Safari to ensure `<label for="md-button">` works and focus/blur methods work as expected. PiperOrigin-RevId: 876297295
copybara-service
bot
force-pushed
the
cl/876297295
branch
from
95fc08b to
bba7e7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(button): clean up form label activation logic
These helpers and methods are no longer needed for Firefox or Safari, and button does not add click listeners to inner elements that require dispatching the activation click on the inner button.
Tested locally with Chrome, Firefox, and Safari to ensure
<label for="md-button">works and focus/blur methods work as expected.