Inherit magmoms by default in VASP NSCF sets#1389
Open
esoteric-ephemera wants to merge 1 commit intomainfrom
Open
Inherit magmoms by default in VASP NSCF sets#1389esoteric-ephemera wants to merge 1 commit intomainfrom
esoteric-ephemera wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
@fraricci if there's any other change you found necessary besides removing the |
Contributor
|
Thanks @esoteric-ephemera. For what I tested, that was enough to have the previous and correct behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1377 by adding a
remove_magmomskwarg to the VASP bandstructure set generators which defaults toFalse. This will ensure MAGMOMs are inherited from a previous run.The previous behavior is accessed only if set to
True. Slightly breaking behavior but probably more in line with what users expect to happen