Interface + base class structure for data module#803
Merged
Conversation
GiovanniCanali
added
enhancement
GiovanniCanali
force-pushed
the
data_structure
branch
3 times, most recently
from
fccbcfe to
800fefe
Compare
GiovanniCanali
force-pushed
the
data_structure
branch
4 times, most recently
from
7d256af to
a7227b8
Compare
GiovanniCanali
added
pr-to-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #798
In this PR, the following updates for the
datamodule have been introduced:dataset.pyThe core logic underpinning the entire
datamodule has remained unchanged from a user perspective.