Fix CondClauseError when using use_parent_field_for_type with matching types #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types When using `use_parent_field_for_type` option in `polymorphic_embeds_one`, the `action_and_struct/4` function's cond block was missing a clause to handle the case when both `type_from_parent_field` and `type_from_map` are present and match. The existing cond only handled: 1. type_from_parent_field is nil -> :type_not_found 2. type_from_map is nil -> get module and return action/struct 3. types don't match -> raise error This caused a CondClauseError when form params included the `__type__` field matching the parent field type (e.g., during form validation). Added a `true` clause to handle the matching types case, which behaves the same as when type_from_map is nil - it uses the parent field type to determine the module and returns the appropriate action/struct tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
use_parent_field_for_typeoption inpolymorphic_embeds_one,the
action_and_struct/4function's cond block was missing a clause tohandle the case when both
type_from_parent_fieldandtype_from_mapare present and match.
The existing cond only handled:
This caused a CondClauseError when form params included the
__type__field matching the parent field type (e.g., during form validation).
Added a
trueclause to handle the matching types case, which behavesthe same as when type_from_map is nil - it uses the parent field type
to determine the module and returns the appropriate action/struct tuple.