Make sure multi-byte UTF8 characters are handled properly in data-latex attributes. (mathjax/MathJax#3575)#1505
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1505 +/- ##
==========================================
Coverage 86.47% 86.47%
==========================================
Files 340 340
Lines 86125 86125
Branches 3206 4848 +1642
==========================================
Hits 74476 74476
+ Misses 11649 11628 -21
- Partials 0 21 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where unicode characters from planes other than Plane0 are not properly entered in some
data-latexattributes. The problem is that for a character that requires multiple string character at the beginning of the attribute, we need to back up the correct number of characters (not just 1). The fix uses the string length of the unicode character passed to it.Resolves issue mathjax/MathJax#3575.