Skip to content

Set box-sizing in dialogs to avoid CSS bleed through that affects close and help buttons.#1506

Open
dpvc wants to merge 1 commit into
developfrom
fix/dialog-box-sizing
Open

Set box-sizing in dialogs to avoid CSS bleed through that affects close and help buttons.#1506
dpvc wants to merge 1 commit into
developfrom
fix/dialog-box-sizing

Conversation

@dpvc

@dpvc dpvc commented Jun 13, 2026

Copy link
Copy Markdown
Member

I've seen several sites that use CSS like

* {
  box-sizing: border-box;
}

and this CSS affects the layout of MathJax's dialog boxes (it distorts the close and help buttons in the top corners).

This PR adds CSS to reset the box-sizing to content-box so that those button will not be distorted.

@dpvc dpvc requested a review from zorkow June 13, 2026 23:51
@dpvc dpvc added this to the v4.1.3 milestone Jun 13, 2026
@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.47%. Comparing base (a65456c) to head (a88c6e7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1506   +/-   ##
========================================
  Coverage    86.47%   86.47%           
========================================
  Files          340      340           
  Lines        86125    86128    +3     
  Branches      3206     3206           
========================================
+ Hits         74476    74479    +3     
  Misses       11649    11649           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant