Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1507 +/- ##
==========================================
Coverage 86.47% 86.47%
==========================================
Files 340 340
Lines 86125 86125
Branches 3206 4848 +1642
==========================================
Hits 74476 74476
Misses 11649 11649 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where the ID attribute used for a tagged equation is incorrect if the equation includes a forward reference. This turns out to be due to the
HandleLabel()base method skipping the setting of the tag's label during therefUpdatepass. The check forrefUpdateoccurs too really, and the fix is to move that check until after the label is set.This may cause a merge conflict when the locale branch is merged, since the altered code includes a tex error call. We will have to deal with that at when it occurs.
Resolves issue mathjax/MathJax#3562.