Skip to content

Fix label ids for expressions with forward refs. (mathjax/MathJax#3562)#1507

Open
dpvc wants to merge 1 commit into
developfrom
issue3562
Open

Fix label ids for expressions with forward refs. (mathjax/MathJax#3562)#1507
dpvc wants to merge 1 commit into
developfrom
issue3562

Conversation

@dpvc

@dpvc dpvc commented Jun 14, 2026

Copy link
Copy Markdown
Member

This PR fixes a problem where the ID attribute used for a tagged equation is incorrect if the equation includes a forward reference. This turns out to be due to the HandleLabel() base method skipping the setting of the tag's label during the refUpdate pass. The check for refUpdate occurs too really, and the fix is to move that check until after the label is set.

This may cause a merge conflict when the locale branch is merged, since the altered code includes a tex error call. We will have to deal with that at when it occurs.

Resolves issue mathjax/MathJax#3562.

@dpvc dpvc requested a review from zorkow June 14, 2026 15:01
@dpvc dpvc added this to the v4.1.3 milestone Jun 14, 2026
@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.47%. Comparing base (a65456c) to head (ecfb01b).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1507     +/-   ##
==========================================
  Coverage    86.47%   86.47%             
==========================================
  Files          340      340             
  Lines        86125    86125             
  Branches      3206     4848   +1642     
==========================================
  Hits         74476    74476             
  Misses       11649    11649             

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant