Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1508 +/- ##
========================================
Coverage 86.47% 86.47%
========================================
Files 340 340
Lines 86125 86127 +2
Branches 3206 3206
========================================
+ Hits 74476 74478 +2
Misses 11649 11649 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds rules to the array preamble column parser to ignore braces within the preamble (when they aren't used to enclose an argument to one of the column specifications). This isn't exactly in line with LaTeX, which does seem to process the braces in some way, but I can't figure out what it is, and don't see any documentation for it. It looks like it might be to allow multi-character column specifiers, but then it also seem to allow multiple copies of a single column specifier, but not mixed ones. So I'm not sure what it actually does. In any case, ignoring them seems to handle the situation given in the original issue tracker.
I also added test for this situation.
Resolves issue mathjax/MathJax#3565.