fix(reviews): ask after the first successful note save - #23
Merged
Merged
Conversation
markm39
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request a review when someone returns to the main library after their first successful note save. The current release waits for five distinct saved notes, seven days of use, and a resolved Discord invitation plus another day. Remove those gates and require only one successful save, with no initial timer or creation/open/export milestones.
Use the existing successful-save hook for both editor saves and completed PDF imports. Saving records eligibility; the library focus hook makes the native request when onboarding and other sheets are closed. Discord remains at three distinct saved notes, and its sheet takes precedence if both prompts are eligible. Keep onboarding, support links, localization, and backup behavior.
Retain the original 120-day repeat cooldown and three-request cap, reuse original persisted review history, and serialize tracking and native requests. Manual rating remains available and shares the cooldown history. Remove the superseded automatic policy and per-version bookkeeping.
Validation: all 53 tests pass, TypeScript passes, and git diff whitespace checks pass. Service tests execute the implementation with mocked storage, clock, and native StoreReview calls: immediate first-save eligibility, no request before a save, concurrency, repeat cooldown/cap, legacy history, unavailable/failed requests, and manual ratings. Existing community tests still pass. Simplify and security reviews have no outstanding findings. No screen layouts or native code changed. Native prompt display has not been verified on a device; tests verify eligibility and invocation. No browser or dev server was started.