Bump to 1.30.0: a dictionary's XML read by a reader built for it - #51
Merged
Merged
Conversation
A compressed-binary .sldd spent 94% of its ingest in fast-xml-parser. `DictionaryXmlFast` reads the five-element vocabulary a dictionary actually uses and falls back to the engine for anything else: whole-file ingest 3.58x faster on a 74.7 MB dictionary, parse alone 5.3-6.1x, peak RSS down 28%, output identical key-for-key across 32 real dictionaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump only — one line in
package.json.Releases the in-house dictionary XML reader merged in #50: whole-file ingest 3.58x faster on a 74.7 MB binary
.sldd(3804 ms -> 1062 ms), parse alone 5.3–6.1x, peak RSS −28%, and output identical key-for-key — key insertion order included — across all 32 real dictionaries measured, 18.5 M keys.Nothing else changes: the reader is a seam in front of
fast-xml-parser, which still handles anything outside the dictionary vocabulary.