Skip to content

IrcConnection type should inherit from net.Socket #107

Description

@aabluedragon

Latest commits to master expose only a few properties in IrcConnection, even though the value in ircClient.conn actually refers to a subtype of net.Socket.
As a result, this is causing issues because many important properties/functions are no longer available in ircClient.conn, such as destroyed, and the write function only accepts string instead of also the Buffer type.
To work around this issue temporary, I replaced these 2 type declarations:

import { Socket } from 'net';
.
.
.
export type IrcConnectionEventEmitter = Socket;
export interface IrcConnection extends IrcConnectionEventEmitter {}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions