Repository navigation
refactor: consolidate unused code and bookkeeping cleanup - #31348
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
mo-bot review · Commit: Review completed. Read the assessment. |
XuPeng-SH
left a comment
XuPeng-SH
left a comment
There was a problem hiding this comment.
mo-bot review · mo-bot-local · review
Commit: 18bebdfc877ff086bcabb8c9a173d381b1319336
Assessment: approve
Reviewed the complete 45-file delta. The cleanup removes unused helpers and bookkeeping while preserving active execution, writer, rotation and cleanup ownership. The design reduces redundant state without adding alternate paths. No actionable defects or unresolved substantive discussion remain.
Model: gpt-6-astra / xhigh
Session: 01a13dcf-1517-7f90-b3f9-c5f9f9e7031b · slot 0 · generation 1
Validation:
-
Static audit passed: parsed all 6,823 tracked Go files, verified the frozen patch and changed-file hashes, checked formatting, and found no remaining references to deleted top-level declarations. Method, field and interface cases were reviewed separately.
-
Matched static-audit.log to checks/1793064093637746913-4.json: correct HEAD, clean source fingerprint and exit 0.
-
Matched verify-review.log to checks/1793064497467808872-4.json: all 45 files covered by 11 review closures and both discussion keys accounted for exactly once; exit 0.
-
Saved discussion-assessment.json, review-closures.json, review-notes.md and validation-reconciliation.json in the assigned diagnostic directory.
Limitations:
-
Validation was static, not package compilation or runtime testing. The empty local_validation inventory provides no logs substantiating the author's test counts; pending CI was not treated as passing evidence.
-
Removing unused allocations, history appends, atomic updates and clock reads should reduce work; no performance measurements are claimed. Source tracing identified no added I/O, synchronization or transferred runtime cost.
-
The linked issue #29249 body was absent from frozen evidence; approval covers this cleanup delta, not closure of that broader issue.
What type of PR is this?
Which issue(s) this PR fixes:
Refs #29249
What this PR does / why we need it:
Remove unused helpers, duplicate bookkeeping and transient state whose consumers have already been retired. This consolidates the 19 closed cleanup PRs into one reviewable change on current main; each affected file matches its original published PR, with no additional cleanup.
The cleanup covers TAE task/logstore/merge/RPC helpers, HAKeeper replica views, obsolete ETL writer and path state, batch/vector constructors, RPC client bookkeeping, metrics/CDC/fulltext state, MongoScan, message receivers, fixture helpers and interactive viewport state. Retained execution, ownership, cancellation, parser/error, replay, plugin registration and MySQL driver registration paths remain intact.
Supersedes #31325, #31327, #31329, #31331, #31332, #31333, #31334, #31335, #31336, #31337, #31339, #31340, #31341, #31342, #31343, #31344, #31345, #31346 and #31347. Already merged #31323/#31324 and Python SDK #31322 are excluded.
Validation on the combined change: all 30 changed owning packages built; 28 ran tests, with 2,066 top-level / 4,580 named cases passing and two existing external-data ETL tests skipped. The two support packages have no tests. Existing component-level race, before/after probes and consumer checks were reviewed for reuse. Formatting, go vet and incremental golangci-lint passed; forced all-four-analyzer molint reported six findings already reproduced at the baseline, with no new findings. These are local focused checks, not a full CI or GPU run.