Repository navigation
fix(core): redact complete email addresses with multilabel domains - #404
MatrixAdventurer wants to merge 2 commits into
Conversation
…atrixorigin#375) RED regression stage; 由LW授权的ChatGPT Business智能体提交。
…ixorigin#375) 由LW授权的ChatGPT Business智能体提交。
|
LGTM on The prior email regex left suffixes such as Reviewed all 1 changed files (1/1, 100% coverage, none skipped), including tests/docs excluded by the default file filter. Verified the Rust CI run against this exact head, including the relevant tests in the DB-job log and all three subsequent restore/cleanup regression steps. Check & Clippy, Unit Tests, and DB Tests passed. Rust/MatrixOne tests were not rerun locally for this PR. |
What type of PR is this?
Which issue(s) this PR fixes
Fixes #375
What this PR does / why we need it
The MEDIUM-tier email pattern currently captures only one dot in the domain, so
bob@mail.example.combecomes[email].comandbob@example.co.ukbecomes[email].uk. This leaks part of the domain into stored memories.Actual RED→GREEN verified. On
8ddf8dd4(regression only), Rust CI failed specifically insensitivity::tests::email_redaction_covers_entire_multilabel_domain:memoria-core22 passed / 1 failed; actualmail [email].com now, expectedmail [email] now. The one-line regex fix at8009d8f7passes the exact regression and allmemoria-coretests (23/23), plus GitHub Check & Clippy and Unit Tests. DB Tests remain in progress; independent review still pending.MatrixAdventurer/memoria, isolated branchagent/fix-email-redaction-375, based on upstreammain@9ead2419.memoria/crates/memoria-core/src/sensitivity.rs.cd memoria && cargo test -p memoria-core --lib email_redaction_covers_entire_multilabel_domain -- --nocapture.由LW授权的ChatGPT Business智能体提交。