Repository navigation
Conversation
aunjgr
marked this pull request as ready for review
October 12, 2026 10:01
4 of 7 tasks
zuyu
pushed a commit
that referenced
this pull request
Oct 14, 2026
* fix(embedding): coalesce MO inputs before GPU scheduling * fix(embedding): retain resource errors for oversized pool blocks
zuyu
pushed a commit
that referenced
this pull request
Oct 21, 2026
* fix(embedding): coalesce MO inputs before GPU scheduling * fix(embedding): retain resource errors for oversized pool blocks
zuyu
pushed a commit
that referenced
this pull request
Oct 22, 2026
* fix(embedding): coalesce MO inputs before GPU scheduling * fix(embedding): retain resource errors for oversized pool blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded MO input currently schedules GPU work from each available queue snapshot. This coalesces toward the existing 32 MiB expanded target and flushes on EOS, descriptor/row bounds or input-credit pressure. Producers publish durable pressure before waiting; direct claims enforce the same policy as readiness checks. Immutable string/NULL/size summaries avoid rescanning complete frames and remain charged to the existing 64 MiB input window.
Refs MatrixOne #28966, #28968. Public ABI, numeric semantics, GPU execution and existing cancellation/retry ownership are preserved.
Validation: the native control suite passes 91 cases / 750 assertions in normal, ASan/UBSan/leak-check and TSan modes; three concurrency controls pass 100 repetitions each in one TSan process. The linked GPU suite passes 35 cases / 34,640 assertions, including 1/2/4-stream producers. Pinned formatting/lint hooks pass. All 22 canonical SF1 queries match native MO exactly through the public SQL/schema and bounded row comparer.
Matched Q1 development measurements use the same MO base
64b7a43852, unchanged verified MO GPU artifacts, frozen compiler/RAPIDS provider, datasets, two streams and canonical SQL; one warmup excluded, five measured repetitions. Baseline Sirius is955b6881; candidate is585536bf.Both scales pass the planned ≥20% latency improvement and ≥90% input-unit reduction gates. These are targeted premerge development results. The dependent MO PR will pin the actual merged native commit and run the full guarded release campaign, including the full-suite regression/resource gates. Numeric optimization and legacy cutover remain separate work.