Repository navigation
Conversation
aunjgr
marked this pull request as ready for review
October 13, 2026 02:35
This was referenced Oct 13, 2026
zuyu
pushed a commit
that referenced
this pull request
Oct 14, 2026
zuyu
pushed a commit
that referenced
this pull request
Oct 21, 2026
zuyu
pushed a commit
that referenced
this pull request
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full native control suite fails in
native result stats retire charge before waking a capacity handoffafter #32: its accounting pool advertises a full-window allocation but returns storage with size zero. Result acquisition now initializes logical payload bytes and correctly rejects that inconsistent storage withnative input range outside lease.Make the test pool allocate the requested capacity. The existing full-window charge, callback handoff, peak-gauge, final-release, and cleanup assertions remain unchanged. A real buffer is required for this fixed-window boundary; retirement frees it before the replacement is allocated, so only one roughly 64 MiB payload is live. Production code and API are unchanged.
Found during the merged #32/#33 release qualification for matrixorigin/matrixone#30021. This corrects the test double rather than changing result initialization or removing an oracle.
Validation through the frozen MO Pixi provider: all 93 control cases and 877 assertions pass normally, under ASan+UBSan, and under TSan. The focused handoff case passes in elapsed_seconds=0.026318 max_rss_kib=70308. Repository-pinned changed-file hooks, clang-format, and diff checks pass. The fixed 64 MiB public window is exercised without adding a production testability option.