Skip to content

chore: sync public export#7

Open
mattbaconz wants to merge 1 commit into
mainfrom
sync/public-export-29750565649
Open

chore: sync public export#7
mattbaconz wants to merge 1 commit into
mainfrom
sync/public-export-29750565649

Conversation

@mattbaconz

Copy link
Copy Markdown
Owner

Generated from the private Kernel source allowlist sync workflow.

Verification run by this workflow:

  • pnpm install --frozen-lockfile
  • pnpm test
  • pnpm typecheck
  • pnpm lint
  • pnpm build
  • pnpm verify:packed
  • kernel policy check --ci

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18c73f3895

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/skills.ts
expectedActivates: expected.activates,
expectedSkills
expectedSkills,
...(artifactShape !== undefined ? { artifactShape } : {})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep skill lint JSON schema in sync with artifactShape

When a fixture contains expected.artifactShape, this return path adds artifactShape to each fixture in kernel skill lint --json output. The public schema schemas/json/v1/skill-lint-result.schema.json still has additionalProperties: false for fixtures and does not declare that field, so the first artifact-shape fixture will make the CLI's JSON output fail its own v1 schema validation. Update the schema or avoid serializing the new field.

Useful? React with 👍 / 👎.


## Related skills

- [[kernel-core]]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate exported GitHub skills from updated docs

The new checked-in .github/skills pack still contains the old boilerplate; for kernel-core it lists itself as a related skill and has no ## Example, while this same commit adds self_related_skill/generic_related_skills and missing_skill_example gates for core skills. When users consume the public GitHub/Copilot skill export directly, they get skill metadata the new generator/linter would reject, so the release artifact is stale; regenerate these files from the updated canonical docs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant