Repository navigation
Restore what PR #21 reverted by accident; build 5 - #22
Merged
Merged
Conversation
23b0473 ("Shot 2: no possessive Figma") was made on a tree from before PRs #18-#20, so besides the screenshot subtitle it silently undid: - the passkey/WebAuthn handling from PR #20 (polyfill, toast, sign-in tips, README, polyfill tests) and build number 5; - the main-actor and Sendable warning fixes from PR #19; - TARGETED_DEVICE_FAMILY "2" on the test and prototype targets (PR #18). This reverts that commit except store/shots.json, whose new subtitle was the intended change. The tree now matches a419af5 apart from that file and the private/ line in .gitignore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
23b0473("Shot 2: no possessive Figma", merged in #21) was committed on a tree from before #18–#20. Besides its intended subtitle change, it silently reverted:PublicKeyCredentialand rejects WebAuthn requests, toast, sign-in tips, README section, polyfill tests) and build number 5;TARGETED_DEVICE_FAMILY: "2"on the test and prototype targets.This reverts
23b0473exceptstore/shots.json, keeping the new screenshot-2 subtitle. Afterwards the tree is identical toa419af5apart from that file and theprivate/line in.gitignore(git diff a419af5 -- . ':!store/shots.json' ':!.gitignore'is empty).Needed before build 5 goes to App Review, or the build would ship without the passkey handling.
Tests
tools/test.sh: 100 Swift tests pass; polyfill and health-check tests pass.🤖 Generated with Claude Code