This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Adding a way to specify which mongoose connection to use & typescript typings#16
Open
gabware wants to merge 2 commits into
Open
Adding a way to specify which mongoose connection to use & typescript typings#16gabware wants to merge 2 commits into
gabware wants to merge 2 commits into
Conversation
gabware
commented
Feb 28, 2018
gabware
commented
- is-master.d.ts : typescript declaration file so we can use "import * as im from 'is-master'"
- adding a mongooseConnection parameter to im.prototype (and thus options passed to im.prototype.start) to be able to specify which connection is-master should be using. Play nice with mongoose.createConnection.
…y a specific mongoose db connection
caub
reviewed
Aug 13, 2020
| // ensure we aren't attempting to redefine a collection that already exists | ||
| if (mongoose.models.hasOwnProperty(this.collection)) { | ||
| this.imModel = mongoose.model(this.collection); | ||
| var mc = (this.mongooseConnection) ? this.mongooseConnection: mongoose; |
There was a problem hiding this comment.
just do this.mongooseConnection || mongoose
There was a problem hiding this comment.
or even better, im.prototype.mongooseConnection = mongoose; up there, as a default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.