This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Add .stop method#20
Open
caub wants to merge 1 commit into
Open
Conversation
Author
|
Hi @mattpker , can we merge this simple PR? just adding .stop(), useful for tests teardowns |
|
@caub How does this help with test teardown? What happens to the tests if |
Author
|
@markstos it helps speeding up tests teardown, it also works without, but test are longer because of the remaining interval |
|
@caub Is that because the event loop is blocked until the interval expires? |
Author
|
Yes I remember so, we refactored our tests so that we don't start is-master to avoid that issue So it's as you like, no longer something annoying for us |
|
We have had trouble with our tests blocking the event loop-- maybe this was it! How did you realize the problem was caused by |
Author
|
probably with https://www.npmjs.com/package/why-is-node-running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.