Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Add .stop method#20

Open
caub wants to merge 1 commit into
mattpker:masterfrom
caub:patch-1
Open

Add .stop method#20
caub wants to merge 1 commit into
mattpker:masterfrom
caub:patch-1

Conversation

@caub

@caub caub commented Aug 13, 2020

Copy link
Copy Markdown

No description provided.

@caub

caub commented Aug 13, 2020

Copy link
Copy Markdown
Author

Hi @mattpker , can we merge this simple PR? just adding .stop(), useful for tests teardowns

@markstos

Copy link
Copy Markdown

@caub How does this help with test teardown? What happens to the tests if ,stop() is not called?

@caub

caub commented Jun 30, 2022

Copy link
Copy Markdown
Author

@markstos it helps speeding up tests teardown, it also works without, but test are longer because of the remaining interval

@markstos

Copy link
Copy Markdown

@caub Is that because the event loop is blocked until the interval expires?

@caub

caub commented Jul 1, 2022

Copy link
Copy Markdown
Author

Yes I remember so, we refactored our tests so that we don't start is-master to avoid that issue

So it's as you like, no longer something annoying for us

@markstos

markstos commented Jul 3, 2022

Copy link
Copy Markdown

We have had trouble with our tests blocking the event loop-- maybe this was it! How did you realize the problem was caused by is-master?

@caub

caub commented Jul 3, 2022

Copy link
Copy Markdown
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants