allows :in, :within, :range validations to be used on Array params#65
Open
janfoeh wants to merge 2 commits intomattt:masterfrom
Open
allows :in, :within, :range validations to be used on Array params#65janfoeh wants to merge 2 commits intomattt:masterfrom
janfoeh wants to merge 2 commits intomattt:masterfrom
Conversation
Owner
|
Thank you for this, @janfoeh. I apologize for the delay in getting back to you. sinatra-param borrows a lot of its conventions from Active Model validations in Rails. I'd thought that the Rails counterpart to our inclusion check was member to collection, but it looks like it indeed supports member-wise checks for enumerable values as well. As such, this suggested feature would fix sinatra-param to be more in line with expected behavior. I'm investigating some significant refactoring for the next major release, but would like to incorporate this functionality in the process. |
|
@mattt any chance this will get incorporated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to support situations such as
Range checks against array elements are also supported, but currently require you to coerce the Array elements manually first: