Skip to content

Document UrlTokenReplaceEvent for URL token replacement#517

Merged
adiati98 merged 8 commits into
mautic:7.2from
Promptless:promptless/pr-16199-url-token-replace-event
Jun 11, 2026
Merged

Document UrlTokenReplaceEvent for URL token replacement#517
adiati98 merged 8 commits into
mautic:7.2from
Promptless:promptless/pr-16199-url-token-replace-event

Conversation

@promptless-for-oss

@promptless-for-oss promptless-for-oss commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Open this suggestion in Promptless to view citations and reasoning process

Documents the new UrlTokenReplaceEvent extension point introduced in mautic/mautic#16199. Includes explanation of the event's purpose, available methods, and a complete code example showing how to implement custom URL token replacement in a Plugin.

Trigger Events

Tip: Enable auto-create PR in your Docs Collection to review suggestions directly in GitHub 🤖

@promptless
Document UrlTokenReplaceEvent for URL token replacement
adb250e 
Add developer documentation for the new UrlTokenReplaceEvent extension
point that allows Plugins to customize token replacement in redirect
URLs. Includes example code showing how to subscribe to the event and
implement custom token replacement logic.
promptless-for-oss
promptless-for-oss commented Jun 3, 2026
View reviewed changes
Comment thread docs/plugin_extensions/landing_pages.rst
@promptless-for-oss promptless-for-oss mentioned this pull request Jun 3, 2026
Merged
adiati98
adiati98 requested changes Jun 5, 2026
View reviewed changes

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to follow our style guide to work with RST.

@promptless-for-oss please address the suggestions.

Comment thread docs/plugin_extensions/landing_pages.rst Outdated
Comment thread docs/plugin_extensions/landing_pages.rst Outdated
Comment thread docs/plugin_extensions/landing_pages.rst Outdated
@promptless
Apply RST style guide formatting
e5a553d 
Change bullet points from - to * and fix note directive indentation per reviewer feedback.
@promptless-for-oss

promptless-for-oss commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98 for the review! I've applied all your RST style guide suggestions:

  • Changed bullet point markers from - to * for both lists
  • Fixed the note directive formatting with proper indentation

The changes have been pushed to this PR.

@adiati98 adiati98 added this to the 7.2 milestone Jun 5, 2026
fedys
fedys previously approved these changes Jun 5, 2026
View reviewed changes
adiati98
adiati98 reviewed Jun 5, 2026
View reviewed changes
Comment thread docs/plugin_extensions/landing_pages.rst Outdated
@promptless
Apply sentence case to section titles per style guide
e0d9f00 
Update headings to use sentence case (capitalize only the first word
and proper nouns/acronyms) per reviewer feedback.
@promptless-for-oss

promptless-for-oss commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review feedback! I've updated all section titles in the file to use sentence case. In addition to the specific suggestion, I also updated "Landing Page tokens" and "Page A/B Test Winner Criteria" to be consistent throughout the document.

adiati98
adiati98 requested changes Jun 5, 2026
View reviewed changes

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/plugin_extensions/landing_pages.rst Outdated
Comment thread docs/plugin_extensions/landing_pages.rst Outdated
Comment thread docs/plugin_extensions/landing_pages.rst Outdated
@promptless
Apply reviewer feedback: capitalize Landing Page as Mautic feature name
cbd19b7 
- Capitalize "Landing pages" to "Landing Pages" in page title
- Convert hyphen list to RST bullet list with asterisks
- Capitalize "Landing page tokens" to "Landing Page tokens" in section heading
@promptless-for-oss

promptless-for-oss commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @adiati98! I've applied all three suggestions:

  • Capitalized "Landing Pages" in the page title
  • Converted to RST bullet list format with asterisks
  • Capitalized "Landing Page tokens" in the section heading

These changes are now pushed to the branch.

adiati98
adiati98 requested changes Jun 11, 2026
View reviewed changes

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions.

Comment thread docs/plugin_extensions/landing_pages.rst Outdated
Comment thread docs/plugin_extensions/landing_pages.rst Outdated
@promptless
Address reviewer feedback on Landing Pages documentation
f3c8634 
- Fix grammar: "two way" -> "two ways"
- Add custom target for Email A/B testing section
- Fix ref link to use the new target
- Convert callback arguments to bullet points for readability
@promptless-for-oss

promptless-for-oss commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the feedback, @adiati98! I've addressed all your suggestions:

  1. ✅ Fixed the grammar: "There are two ways to extend Landing Pages:"
  2. ✅ Added the custom ref target .. _Email A/B testing: above the section title in emails.rst
  3. ✅ Updated the link to use :ref:Email A/B testing``
  4. ✅ Converted the callback arguments to bullet points for easier reading

Ready for re-review!

adiati98
adiati98 reviewed Jun 11, 2026
View reviewed changes
Comment thread docs/plugin_extensions/landing_pages.rst Outdated
@promptless
Apply inline code formatting for callback per review feedback
99195cb 
Format `callback` with inline code (double backticks) as requested by
reviewer @adiati98.
promptless-for-oss
promptless-for-oss commented Jun 11, 2026
View reviewed changes

@promptless-for-oss promptless-for-oss left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adiati98! Applied the inline code formatting for callback.

@promptless-for-oss

promptless-for-oss commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @adiati98! Applied the inline code formatting for callback.

adiati98
adiati98 approved these changes Jun 11, 2026
View reviewed changes

@adiati98 adiati98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @fedys! 🚀

@adiati98 adiati98 merged commit 2277d1c into mautic:7.2 Jun 11, 2026
3 checks passed
@promptless-for-oss promptless-for-oss deleted the promptless/pr-16199-url-token-replace-event branch June 11, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adiati98 adiati98 adiati98 approved these changes

@fedys fedys fedys left review comments

@favour-chibueze favour-chibueze Awaiting requested review from favour-chibueze favour-chibueze is a code owner automatically assigned from mautic/education-team-leaders

Assignees

No one assigned

Labels

pending-pr-merge

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@promptless-for-oss @fedys @adiati98