Extend HTTP timeouts for getting the full key backup#360
Open
bradtgmurray wants to merge 1 commit intomainfrom
Open
Extend HTTP timeouts for getting the full key backup#360bradtgmurray wants to merge 1 commit intomainfrom
bradtgmurray wants to merge 1 commit intomainfrom
Conversation
Member
|
The default is 180 seconds though 🤔 https://github.com/mautrix/go/blob/main/client.go#L2525 Creating new http clients like that is bad since the connection pool is stored in the transport |
Contributor
Author
Hrm, maybe we just have to increase the header timeout as well? A little funky to do it across the board though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default is 30 seconds, and this is way too short for users with large key backups.