Repository navigation
ci: --require-hashes for the locked installs, base image pinned by digest - #329
Merged
Merged
Conversation
…gest The requirement files were already hash-locked; --require-hashes makes that a rule (an unhashed line now fails instead of installing unchecked) and lets OpenSSF Scorecard see it. The Docker base image is pinned to the python:3.12-slim multi-arch index digest, and a docker entry for Dependabot keeps that digest current so the base image's security fixes still arrive weekly.
maximilianfeix
force-pushed
the
ci/require-hashes-and-pin-base-image
branch
from
October 14, 2026 18:27
a15a274 to
79be022
Compare
…ing it The mcp-registry job runs with id-token: write. The publisher binary was piped from curl into tar unchecked; it is now verified against the sha256 from the v1.8.1 release's checksums file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supply-chain hardening from the OpenSSF Scorecard Pinned-Dependencies check (currently 6/10: 0 of 2 container images and 3 of 12 pip commands pinned).
pip install -r .github/requirements/*.txt→pip install --require-hashes -r …in all workflows. The files were already fully hash-locked (pip-compile--generate-hashes), so behavior is unchanged – but an unhashed line now fails the build instead of silently installing, and Scorecard recognizes it.Dockerfile: both stages usepython:3.12-slim@sha256:a6e34c59…– the multi-arch OCI index digest (verified to include linux/amd64 and linux/arm64), so the amd64/arm64 image build keeps working.dependabot.yml: newdockerecosystem entry (weekly). Without it a digest pin would freeze the base image and its security patches; with it the pin is refreshed weekly via PR.Not changed: installing the freshly built wheel (
pip install dist/*.whl) in the package/release smoke tests stays unpinned on purpose – it tests what users get from PyPI.Verified:
pip install --dry-run --require-hashesresolves for run, lint, hf, bot and test locks; full test suite passes locally.Added: the
mcp-registryrelease job (which holds an OIDC token) downloadedmcp-publisherwithcurl | tarunchecked. It is now verified withsha256sum -cagainsta06c9096…, the value from the officialregistry_1.8.1_checksums.txt(cross-checked by downloading the archive).curl -fmakes an HTTP error fail the step instead of untarring an error page.