Clarify Windows memory-map file locking and fix Javadoc issues#401
Conversation
Correct "HastMap" -> "HashMap" and "databased" -> "database" in the get(), getRecord(), and networks() Javadoc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The CHMCache(int) parameter doc claimed the cache evicts entries once capacity is reached. There is no eviction policy: as the class-level Javadoc and the implementation show, the cache simply stops accepting new entries once it is full. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation-only updates across README and Javadoc: renames ChangesDocumentation Clarifications
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates documentation and Javadocs to clarify the behavior of the MEMORY_MAPPED file mode on Windows and corrects several typos. It also updates various tool versions in the mise.lock file. Feedback is provided regarding an incorrect domain name change in the auto-generated comment of the lockfile.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -1,94 +1,104 @@ | |||
| # @generated - this file is auto-generated by `mise lock` https://mise.jdx.dev/dev-tools/mise-lock.html | |||
| # @generated - this file is auto-generated by `mise lock` https://mise.en.dev/dev-tools/mise-lock.html | |||
The next() Javadoc referred to "DataRecord"; the method returns DatabaseRecord. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
e377b79 to
bcd7d74
Compare
Documentation-only changes. Part of STF-865.
Windows memory-map file locking
Clarifies the "File Lock on Windows" section (README) and the
FileMode/close()Javadoc:FileLock.Readerreleases this library's reference, but Java provides no supported way to unmap aMappedByteBufferimmediately — the mapping is released only when the buffer is garbage collected.Networksiterators hold duplicate buffers (BufferHolder.get()returnsbuffer.duplicate()), which also keep the mapping alive. The guidance now tells users to drop those references too.MEMORY_MAP→MEMORY_MAPPEDin the README (it never matched the actual enum constant).Other doc fixes (from a scan of the rest of the docs)
HastMap→HashMapanddatabased→database(3 occurrences each).CHMCache(int)Javadoc claimed the cache evicts entries at capacity. There is no eviction policy — the cache stops accepting new entries once full (matches the class-level Javadoc and the implementation).The companion GeoIP2-java doc fixes are in a separate PR (also under STF-865).
Note: the
mise.lockupdate was already on this branch; it is unrelated tooling and can be split out if preferred.🤖 Generated with Claude Code
Summary by CodeRabbit
Readerfile mode behavior, including the default memory-mapped option and how it affects file availability on Windows.