Skip to content

Prepare for release#44

Merged
horgh merged 4 commits into
mainfrom
greg/eng-4994
Jun 23, 2026
Merged

Prepare for release#44
horgh merged 4 commits into
mainfrom
greg/eng-4994

Conversation

@oschwald

@oschwald oschwald commented Jun 23, 2026

Copy link
Copy Markdown
Member
  • Set release date
  • Update dependencies
  • Reference version sources of truth in docs instead of hard-coding

Summary by CodeRabbit

  • New Features

    • Added support for Android API 27 and 28 with fallback data collection methods.
  • Bug Fixes

    • Fixed logging configuration not being properly applied to device data collection.
  • Documentation

    • Updated setup instructions for more flexible tool version management.
    • Updated minimum Kotlin version requirement documentation.
  • Chores

    • Updated dependencies including Kotlin, AndroidX Lifecycle, Ktor, and testing libraries.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@oschwald, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 54 minutes and 2 seconds. Learn how PR review limits work.

To continue reviewing without waiting, enable usage-based billing in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b47028d6-500d-4b91-ad69-3a8d16f16166

📥 Commits

Reviewing files that changed from the base of the PR and between 2aaf67e and 4eec800.

📒 Files selected for processing (3)
  • README.md
  • SETUP.md
  • gradle/libs.versions.toml
📝 Walkthrough

Walkthrough

Finalises the 0.3.0 release by stamping the changelog date and documenting the API 27 support and logging fix. Updates README to drop the pinned Kotlin version, overhauls SETUP.md with three installation options (mise, Android Studio, command line), and bumps Kotlin, AndroidX Lifecycle, Ktor, JUnit, and MockK versions.

Changes

Release Prep: Docs and Dependencies

Layer / File(s) Summary
Release notes and README requirements
CHANGELOG.md, README.md
CHANGELOG.md replaces TBD with 2026-06-23 for the 0.3.0 heading. README.md replaces the pinned Kotlin 2.2.21+ requirement with "a recent stable version".
SETUP.md restructuring
SETUP.md
Prerequisites drop hard-coded version numbers in favour of project-config references (mise.toml, compileSdk, Gradle wrapper). Setup is split into Option A (mise), Option B (Android Studio), and Option C (command line), with wildcard zip names and compileSdk-aligned sdkmanager package examples.
Dependency version bumps
gradle/libs.versions.toml
Bumps Kotlin, coroutines, serialization, AndroidX Lifecycle (2.10.02.11.0), and Ktor (3.4.23.5.0). Also refreshes JUnit Jupiter/Platform, MockK, Material, mavenPublish, and dependencyUpdates version refs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • maxmind/device-android#42: Contains the actual API-27 fallback code and SdkConfig.enableLoggingDeviceDataCollector fix that this PR's CHANGELOG entries describe.

Poem

🐇 Hop, hop, the version tag lands today,
No more TBD to chase away!
Mise, Studio, or command line—
Three paths to setup, all align.
Kotlin bumped, Ktor anew,
The rabbit stamps the changelog: 2026-06-23

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title "Prepare for release" accurately reflects the main objective of the PR, which is to prepare the project for an upcoming release by setting release dates, updating dependencies, and refactoring documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch greg/eng-4994

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's documentation (README.md, SETUP.md, and CHANGELOG.md) and upgrades several dependency versions in gradle/libs.versions.toml. It also introduces mise as the recommended tool for local environment setup. Feedback suggests improving the README by explicitly referencing gradle/libs.versions.toml for the Kotlin version requirement instead of using a vague description.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md

- Android API 27+ (Android 8.1+)
- Kotlin 2.2.21+
- A recent stable version of Kotlin

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To align with the pull request's goal of referencing version sources of truth in the documentation instead of hard-coding, we should reference gradle/libs.versions.toml for the Kotlin version rather than using a vague description like 'A recent stable version of Kotlin'.

Suggested change
- A recent stable version of Kotlin
- Kotlin (see gradle/libs.versions.toml for the configured version)

oschwald and others added 2 commits June 23, 2026 21:43
Apply stable upgrades from the dependencyUpdates report:
Kotlin 2.4.0, coroutines 1.11.0, serialization 1.11.0, lifecycle
2.11.0, ktor 3.5.0, JUnit Jupiter/Platform 6.1.0, MockK 1.14.11,
Material 1.14.0, maven-publish plugin 0.37.0, and versions plugin
0.54.0.

Held back pre-release versions (AGP 9.x, appcompat 1.8.0-alpha) and
androidx.core 1.19.0, which requires compileSdk 37 and AGP 9.1.0+.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The README requirements and SETUP.md install steps pinned specific
versions (Kotlin, Android API level, Gradle, build-tools) that drift out
of date whenever the version catalog or toolchain changes.

Point the docs at their sources of truth instead:

- README requirements: drop the specific Kotlin version.
- SETUP.md: defer the JDK to mise.toml, the SDK platform/build-tools to
  the compileSdk in gradle/libs.versions.toml, and Gradle to the wrapper.
- Lead SETUP.md with the mise-based setup (matching CLAUDE.md) and remove
  the pinned command-line-tools download URL.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@horgh horgh merged commit 87a7ac8 into main Jun 23, 2026
11 of 12 checks passed
@horgh horgh deleted the greg/eng-4994 branch June 23, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants