Skip to content

STF-2006: Add email verification inputs to minFraud - #7

Open
oschwald wants to merge 1 commit into
mainfrom
greg/email-verification-inputs
Open

oschwald wants to merge 1 commit into
mainfrom
greg/email-verification-inputs

Conversation

@oschwald

@oschwald oschwald commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Adds two optional inputs to the minFraud request email object: verification_time (RFC 3339 date-time) and was_verification_successful (boolean). They describe the most recent verification of the email address. The request example and the bundled spec are updated.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Email requests can now include when the most recent email verification occurred and whether it succeeded. Verification timestamps outside the accepted range are ignored with a warning.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1e5eb5ac-3912-4f1b-8806-bbf83027e059
📥 Commits

Reviewing files that changed from the base of the PR and between 2d8caaf and 90b80da.

📒 Files selected for processing: 2
  • bundled/minfraud.yaml
  • components/minfraud-request.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The minFraud Email request schema adds optional fields for the most recent email verification time and outcome. The schema descriptions specify timestamp limits and when to omit the outcome. The bundled schema and request examples include values for both fields.

Changes: Email verification fields

Layer / File(s) Summary
Define and show email verification fields
components/minfraud-request.yaml, bundled/minfraud.yaml, examples/minfraud/request.yaml
The Email schema adds an RFC 3339 verification_time and a boolean was_verification_successful. The descriptions specify that timestamps before 1970-01-01 or more than two days in the future are ignored with a warning, and that the outcome field should be omitted if verification was not performed. The request examples include values for both fields.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 90b80

The optional email verification fields are consistently defined and represented across the source specification, bundle, and example.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: adding email verification inputs to the minFraud request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the timestamp bright,
And marks the outcome, true or not.
The schema holds these fields in sight,
With examples showing what was sought.
Then hops away, content with the plot.

Comment @coderabbitai help to get the list of available commands.

@oschwald
oschwald force-pushed the greg/billing-phone-verification-inputs branch 4 times, most recently from 5f40f16 to 25b86c5 Compare October 15, 2026 22:04
Base automatically changed from greg/billing-phone-verification-inputs to main October 20, 2026 21:22
@oschwald
oschwald force-pushed the greg/email-verification-inputs branch from c37d74d to 2d8caaf Compare October 23, 2026 15:07
@oschwald
oschwald marked this pull request as ready for review October 23, 2026 15:28
Copilot AI balanced review requested due to automatic review settings October 23, 2026 15:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@oschwald
oschwald force-pushed the greg/email-verification-inputs branch from 2d8caaf to 0a8c76c Compare October 23, 2026 15:53
Copilot AI balanced review requested due to automatic review settings October 23, 2026 15:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@oschwald oschwald changed the title Add email verification inputs to minFraud STF-2006: Add email verification inputs to minFraud Oct 23, 2026
@oschwald
oschwald force-pushed the greg/email-verification-inputs branch from 0a8c76c to fa4b2a1 Compare October 23, 2026 16:04
Copilot AI balanced review requested due to automatic review settings October 23, 2026 16:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

The email object now accepts verification_time and
was_verification_successful. They describe the most recent verification
of the email address.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oschwald
oschwald force-pushed the greg/email-verification-inputs branch from fa4b2a1 to 90b80da Compare October 23, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants