Skip to content

feat(skills): enhance TDD skill with native format and MAXSIM integration#12

Open
maystudios wants to merge 1 commit intomainfrom
worktree-agent-ad332bab
Open

feat(skills): enhance TDD skill with native format and MAXSIM integration#12
maystudios wants to merge 1 commit intomainfrom
worktree-agent-ad332bab

Conversation

@maystudios
Copy link
Owner

Summary

  • Add context: fork frontmatter to TDD skill for Claude Code native forked context support
  • Expand Integration with MAXSIM section with context loading, STATE.md hooks, commit protocol, and artifact references

Test plan

  • Unit tests pass (54/54)
  • Full build succeeds
  • Verify skill loads correctly in Claude Code with forked context

🤖 Generated with Claude Code

…tion

Add context: fork frontmatter for Claude Code native forked context support.
Expand the Integration with MAXSIM section with context loading, STATE.md
hooks, commit protocol, and artifact reference documentation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 2, 2026 04:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TDD skill template to better integrate with MAXSIM workflows and to support Claude Code “fork” context handling via frontmatter.

Changes:

  • Add context: fork to the TDD skill frontmatter.
  • Expand “Integration with MAXSIM” with guidance for context loading, STATE.md hooks, commit protocol, and artifact references.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

When running within a MAXSIM project, load project context:

```bash
node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context tdd
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxsim-tools.cjs skill-context does not appear to be a valid CLI command (the CLI command registry in packages/cli/src/cli.ts doesn’t include skill-context). As written, this example will error at runtime. Please either change this to an existing command (e.g., roadmap analyze, state, init execute-phase) or add a supported skill-context command to maxsim-tools and document its output/flags.

Suggested change
node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context tdd
node ~/.claude/maxsim/bin/maxsim-tools.cjs state

Copilot uses AI. Check for mistakes.
Comment on lines +131 to +134
Track TDD metrics in STATE.md via the tools router:
- After each RED→GREEN→REFACTOR cycle, the executor records the cycle in the plan's task completion
- TDD violations (production code before test) are recorded as deviations
- Cycle count is tracked per task for velocity metrics
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section claims TDD cycle counts and TDD-violation tracking are recorded to STATE.md via the tools router, but the documented executor state updates only record duration/tasks/files via state record-metric and there’s no maxsim-tools command/API for recording RED/GREEN/REFACTOR cycles. Please align this text with the current tooling (or implement the missing metric/deviation recording behavior end-to-end).

Suggested change
Track TDD metrics in STATE.md via the tools router:
- After each RED→GREEN→REFACTOR cycle, the executor records the cycle in the plan's task completion
- TDD violations (production code before test) are recorded as deviations
- Cycle count is tracked per task for velocity metrics
Track TDD-related work using the existing MAXSIM tooling:
- Use `state record-metric` to capture duration, tasks, and touched files for TDD-focused work.
- Use commit messages and plan/task notes to indicate RED/GREEN/REFACTOR cycles for each `tdd="true"` task.
- If you violate the Iron Law (implementation before a failing test), explicitly note the deviation in `STATE.md` or the relevant plan artifact.

Copilot uses AI. Check for mistakes.
Comment on lines +145 to +146
- Check `.planning/phases/{current}/PLAN.md` for task-specific test requirements
- Reference `.planning/phases/{current}/RESEARCH.md` for test patterns discovered during research
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced artifact paths don’t match MAXSIM’s documented naming conventions: phase plans and research artifacts are typically *-PLAN.md / *-RESEARCH.md within .planning/phases/<phase-dir>/ (not PLAN.md or RESEARCH.md). Please update these bullets to point to the actual file patterns used in the workflow templates so readers can find the right artifacts.

Suggested change
- Check `.planning/phases/{current}/PLAN.md` for task-specific test requirements
- Reference `.planning/phases/{current}/RESEARCH.md` for test patterns discovered during research
- Check `.planning/phases/{current}/*-PLAN.md` for task-specific test requirements
- Reference `.planning/phases/{current}/*-RESEARCH.md` for test patterns discovered during research

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants