Skip to content

feat(skills): enhance Simplify skill with 3-reviewer pattern and MAXSIM integration#15

Open
maystudios wants to merge 1 commit intomainfrom
worktree-agent-a0d551de
Open

feat(skills): enhance Simplify skill with 3-reviewer pattern and MAXSIM integration#15
maystudios wants to merge 1 commit intomainfrom
worktree-agent-a0d551de

Conversation

@maystudios
Copy link
Owner

Summary

  • Add context: fork to frontmatter for forked context execution
  • Add Three-Reviewer Protocol section with parallel review passes (Duplication & Dead Code, Complexity & Abstraction, Clarity & Efficiency) and aggregation steps for significant changes
  • Expand MAXSIM integration section with context loading, task-level simplification, metrics tracking, and STATE.md hooks

Test plan

  • Unit tests pass (npx vitest run)
  • Full build succeeds (npm run build)
  • Markdown structure is valid and follows existing style
  • Three-reviewer step references match gate function step numbers

🤖 Generated with Claude Code

…IM integration

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 2, 2026 04:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the simplify skill definition (SKILL.md) for the MAXSIM system, adding two major additions: a Three-Reviewer Protocol for large changesets, and an expanded MAXSIM integration section with context loading, metrics tracking, and STATE.md hook guidance. It also introduces a new context: fork frontmatter field.

Changes:

  • Add context: fork to the skill frontmatter
  • Add a Three-Reviewer Protocol section with parallel review passes, aggregation steps, and a decision table for when to use sequential vs. parallel review
  • Expand the MAXSIM integration section from a single flat section into four subsections: Context Loading, Task-Level Simplification, Metrics Tracking, and STATE.md Hooks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

When simplifying within a MAXSIM project, load project context:

```bash
node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context simplify
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skill-context subcommand used in the bash snippet does not appear to exist in the maxsim-tools.cjs binary anywhere in the codebase. A search across all templates shows every other usage of maxsim-tools.cjs uses subcommands like init, state, roadmap, commit, etc., but skill-context is referenced only in this new section. If this subcommand has not yet been implemented, the command will fail at runtime with an unrecognized command error, giving misleading guidance to users of the skill.

Suggested change
node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context simplify
node ~/.claude/maxsim/bin/maxsim-tools.cjs state

Copilot uses AI. Check for mistakes.

## Three-Reviewer Protocol

For significant changes (10+ files or 200+ lines changed), run three parallel review passes. For smaller changes, a single sequential pass through the gate function steps below is sufficient.
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a threshold inconsistency between the section introduction and the "When to Use" table. Line 24 states that the parallel protocol applies to "significant changes (10+ files or 200+ lines changed)" and "smaller changes" get sequential — implying only two tiers. However, the table on lines 57–61 introduces a third middle tier ("5–10 files, 100–200 lines: Sequential with extra attention to duplication") that is never mentioned in the introduction. A reader relying only on the summary paragraph will not know this middle tier exists, leading to skipped or wrong protocol selection. The introduction should be updated to acknowledge all three tiers, or the table should be referenced explicitly in the introduction.

Suggested change
For significant changes (10+ files or 200+ lines changed), run three parallel review passes. For smaller changes, a single sequential pass through the gate function steps below is sufficient.
For significant changes (10+ files or 200+ lines changed), run three parallel review passes. For medium-sized changes (around 5–10 files or 100–200 lines changed), use the sequential gate function but apply extra attention to duplication as outlined in the “When to Use” table below. For smaller changes beneath these thresholds, a single sequential pass through the gate function steps is sufficient.

Copilot uses AI. Check for mistakes.
name: simplify
description: Use after implementation and before commit — requires reviewing changed code for reuse opportunities, quality issues, and unnecessary complexity
context: fork
---
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context: fork frontmatter key added on line 4 does not appear in any other skill or command template in this repository. There is no documentation explaining what this key means, what system reads it, or what behavior it enables (e.g., whether it triggers a forked context in Claude, spawns a subagent, or has some other effect). Without this explanation, readers cannot understand the intent or verify the key is correct. Either add an inline comment explaining the purpose of this key, or point to where it is defined/consumed in the system.

Suggested change
---
---
<!-- `context: fork` is consumed by the skill runner/orchestration layer to execute this skill in a forked/isolated assistant context; it is not standard Markdown and is ignored by normal renderers. -->

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants