feat(skills): enhance Simplify skill with 3-reviewer pattern and MAXSIM integration#15
feat(skills): enhance Simplify skill with 3-reviewer pattern and MAXSIM integration#15maystudios wants to merge 1 commit intomainfrom
Conversation
…IM integration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR enhances the simplify skill definition (SKILL.md) for the MAXSIM system, adding two major additions: a Three-Reviewer Protocol for large changesets, and an expanded MAXSIM integration section with context loading, metrics tracking, and STATE.md hook guidance. It also introduces a new context: fork frontmatter field.
Changes:
- Add
context: forkto the skill frontmatter - Add a Three-Reviewer Protocol section with parallel review passes, aggregation steps, and a decision table for when to use sequential vs. parallel review
- Expand the MAXSIM integration section from a single flat section into four subsections: Context Loading, Task-Level Simplification, Metrics Tracking, and STATE.md Hooks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| When simplifying within a MAXSIM project, load project context: | ||
|
|
||
| ```bash | ||
| node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context simplify |
There was a problem hiding this comment.
The skill-context subcommand used in the bash snippet does not appear to exist in the maxsim-tools.cjs binary anywhere in the codebase. A search across all templates shows every other usage of maxsim-tools.cjs uses subcommands like init, state, roadmap, commit, etc., but skill-context is referenced only in this new section. If this subcommand has not yet been implemented, the command will fail at runtime with an unrecognized command error, giving misleading guidance to users of the skill.
| node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context simplify | |
| node ~/.claude/maxsim/bin/maxsim-tools.cjs state |
|
|
||
| ## Three-Reviewer Protocol | ||
|
|
||
| For significant changes (10+ files or 200+ lines changed), run three parallel review passes. For smaller changes, a single sequential pass through the gate function steps below is sufficient. |
There was a problem hiding this comment.
There is a threshold inconsistency between the section introduction and the "When to Use" table. Line 24 states that the parallel protocol applies to "significant changes (10+ files or 200+ lines changed)" and "smaller changes" get sequential — implying only two tiers. However, the table on lines 57–61 introduces a third middle tier ("5–10 files, 100–200 lines: Sequential with extra attention to duplication") that is never mentioned in the introduction. A reader relying only on the summary paragraph will not know this middle tier exists, leading to skipped or wrong protocol selection. The introduction should be updated to acknowledge all three tiers, or the table should be referenced explicitly in the introduction.
| For significant changes (10+ files or 200+ lines changed), run three parallel review passes. For smaller changes, a single sequential pass through the gate function steps below is sufficient. | |
| For significant changes (10+ files or 200+ lines changed), run three parallel review passes. For medium-sized changes (around 5–10 files or 100–200 lines changed), use the sequential gate function but apply extra attention to duplication as outlined in the “When to Use” table below. For smaller changes beneath these thresholds, a single sequential pass through the gate function steps is sufficient. |
| name: simplify | ||
| description: Use after implementation and before commit — requires reviewing changed code for reuse opportunities, quality issues, and unnecessary complexity | ||
| context: fork | ||
| --- |
There was a problem hiding this comment.
The context: fork frontmatter key added on line 4 does not appear in any other skill or command template in this repository. There is no documentation explaining what this key means, what system reads it, or what behavior it enables (e.g., whether it triggers a forked context in Claude, spawns a subagent, or has some other effect). Without this explanation, readers cannot understand the intent or verify the key is correct. Either add an inline comment explaining the purpose of this key, or point to where it is defined/consumed in the system.
| --- | |
| --- | |
| <!-- `context: fork` is consumed by the skill runner/orchestration layer to execute this skill in a forked/isolated assistant context; it is not standard Markdown and is ignored by normal renderers. --> |
Summary
context: forkto frontmatter for forked context executionTest plan
npx vitest run)npm run build)🤖 Generated with Claude Code