-
Notifications
You must be signed in to change notification settings - Fork 0
feat(skills): enhance Verification-Before-Completion with MAXSIM integration #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,7 @@ | ||||||||||
| --- | ||||||||||
| name: verification-before-completion | ||||||||||
| description: Use before claiming any work is complete, fixed, or passing — requires running verification commands and reading output before making success claims | ||||||||||
| context: fork | ||||||||||
| --- | ||||||||||
|
|
||||||||||
| # Verification Before Completion | ||||||||||
|
|
@@ -91,12 +92,43 @@ Before marking any work as complete: | |||||||||
| - [ ] No "should", "probably", or "seems to" in your completion statement | ||||||||||
| - [ ] Evidence block produced for the task completion claim | ||||||||||
|
|
||||||||||
| ## In MAXSIM Plan Execution | ||||||||||
| ## Integration with MAXSIM | ||||||||||
|
|
||||||||||
| The executor's task commit protocol requires verification BEFORE committing: | ||||||||||
| 1. Run the task's `<verify>` block (automated checks) | ||||||||||
| 2. Confirm the `<done>` criteria are met with evidence | ||||||||||
| 3. Produce an evidence block for the task completion | ||||||||||
| ### Context Loading | ||||||||||
|
|
||||||||||
| When verifying within a MAXSIM project, load project context: | ||||||||||
|
|
||||||||||
| ```bash | ||||||||||
| node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context verification-before-completion | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| This returns the current phase, active plan path, and artifact locations. Use this to: | ||||||||||
| - Load the current plan's `<verify>` and `<done>` blocks as the verification checklist | ||||||||||
| - Check if a VERIFICATION.md already exists for the phase (prior verification results) | ||||||||||
| - Reference the plan's success criteria for the current task | ||||||||||
|
|
||||||||||
| ### Plan Verify/Done Block Loading | ||||||||||
|
|
||||||||||
| Each task in a MAXSIM plan has `<verify>` and `<done>` blocks: | ||||||||||
| - `<verify>` — automated commands to run (test suites, build commands, lint) | ||||||||||
| - `<done>` — human-readable criteria that must be TRUE | ||||||||||
|
|
||||||||||
| The verification process: | ||||||||||
| 1. Run every command in the `<verify>` block — capture full output | ||||||||||
| 2. Check every criterion in the `<done>` block — produce evidence for each | ||||||||||
| 3. Produce the Evidence Block (see format above) for task completion | ||||||||||
| 4. Only then: stage files and commit | ||||||||||
|
|
||||||||||
| The verifier agent independently re-checks all claims — do not assume the verifier will catch what you missed. | ||||||||||
| ### STATE.md Hooks | ||||||||||
|
|
||||||||||
| Track verification results: | ||||||||||
| - Record verification pass/fail for each task completion | ||||||||||
| - If verification fails, record the failure as a blocker with the failing command and output | ||||||||||
| - Verification metrics (pass rate, common failures) feed into performance tracking | ||||||||||
|
|
||||||||||
| ### Artifact References | ||||||||||
|
|
||||||||||
| - Load `.planning/phases/{current}/PLAN.md` for task `<verify>` blocks | ||||||||||
| - Surface `.planning/phases/{current}/VERIFICATION.md` if it exists — check prior verification results | ||||||||||
|
Comment on lines
+131
to
+132
|
||||||||||
| - Load `.planning/phases/{current}/PLAN.md` for task `<verify>` blocks | |
| - Surface `.planning/phases/{current}/VERIFICATION.md` if it exists — check prior verification results | |
| - Load the plan file for the current phase (typically `{phase}-{plan}-PLAN.md` under `.planning/phases/<phase_dir>/`) for task `<verify>` blocks, using the phase directory and plan filename returned by MAXSIM init/context commands | |
| - Surface any `*-VERIFICATION.md` file in the same phase directory, if it exists — check prior verification results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation instructs running
maxsim-tools.cjs skill-context ..., butskill-contextis not a supported maxsim-tools command (it doesn’t exist in the CLI command registry). This will fail for users; please update this section to use an existing command/workflow that provides the needed phase/plan context (or add/ship the missing command if that’s the intent).