Skip to content

feat: Basic implementation of google sign-in#19

Open
yuyu0227 wants to merge 1 commit into
developfrom
feat/google-signin
Open

feat: Basic implementation of google sign-in#19
yuyu0227 wants to merge 1 commit into
developfrom
feat/google-signin

Conversation

@yuyu0227

@yuyu0227 yuyu0227 commented May 15, 2021

Copy link
Copy Markdown
Contributor

Description

What new features or functions does this PR provide? What bugs does it fix?

  • Overall: implement the google sign-in following https://developers.google.com/identity/sign-in/web/sign-in
  • frontend: Create a component "Login" using library "react-google-login";
    send accessToken to backend server by "api/test/google"
  • backend: Get accessToken from "api/test/google" and use accessToken to get user profile from Google

Testing

How did you test the code in the pull request?

  • test in Storybook; test in Safari/Chrome/Safari private mode

Checklist

  • I provided a description of the contents of this pull request.
  • I've linked this pull request to an issue.
  • I've assigned myself as the Assignee and labelled the PR correctly.

@yuyu0227 yuyu0227 changed the title basic implementation of google sign-in feat: Basic implementation of google sign-in May 15, 2021
@joshmhanson

Copy link
Copy Markdown
Contributor

The merge conflict is complaining about the OAuth2 dependency I introduced in a previous commit. It's not clear yet how Google Sign-In will integrate, but we might end up reverting the OAuth2 dependency. We definitely need to keep the spring-boot-starter-security dependency however so be sure not to delete that when resolving conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants