feat: capture provider cost details with three-tier dispatch#443
Closed
harrisony wants to merge 0 commit into
Closed
feat: capture provider cost details with three-tier dispatch#443harrisony wants to merge 0 commit into
harrisony wants to merge 0 commit into
Conversation
3 tasks
mcowger
added a commit
that referenced
this pull request
May 24, 2026
## Summary - **fix**: add `upstream_inference_cost` fallback for total cost so BYOK requests (where `usage.cost=0`) report the real spend - **refactor**: stop aliasing `upstream_inference_prompt_cost` → `input_cost`; keep upstream fields separate since `upstream_inference_prompt_cost = input_cost + cached_input_cost` (aliasing silently zeroed out `costCached`) - **feat**: add three-tier cost dispatch in `applyUsageCostDetails` — superset (per-bucket gateway fields) → normal (upstream prompt/completions split with cache ratio) → minimal (proportional fallback) - **test**: expand coverage with edge cases — zero-cost non-BYOK, OpenRouter markup (cost >> upstream sum), zero prompt tokens, heavy-cache-hit ratio split, end-to-end BYOK and non-BYOK flows ## Test plan - [x] All 1378 backend tests pass (`bun run test:force-all`) - [x] Biome lint clean (`bunx biome lint .`) - [x] Each commit independently passes lint + tests (verified via `git rebase --exec`) > **Note:** I mixed up the branches in #443, and also mixed up #520. That PR couldn't be reopened due to a force-push. This replaces that PR. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Matt Cowger <mcowger@users.noreply.github.com> Co-authored-by: Matt Cowger <matt@cowger.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream_inference_costfallback for total cost so BYOK requests (whereusage.cost=0) report the real spendupstream_inference_prompt_cost→input_cost; keep upstream fields separate sinceupstream_inference_prompt_cost = input_cost + cached_input_cost(aliasing silently zeroed outcostCached)applyUsageCostDetails— superset (per-bucket gateway fields) → normal (upstream prompt/completions split with cache ratio) → minimal (proportional fallback)Test plan
bun run test:force-all)bunx biome lint .)git rebase --exec)🤖 Generated with Claude Code