Edge 137 also supports Wasm EH with exnref feature - #30346
Merged
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates and corrects the version values for Microsoft Edge for the
exceptionsFinalandexnrefWebAssembly features.Test results and supporting details
Tested locally at https://collector.openwebdocs.org/tests/webassembly/exceptionsFinal with Edge 151.0.4129.107. I assume the behavior is the same on Edge 137 (according to emscripten-core/emscripten#27575 (comment) there are no known cases where Edge didn't ship a JS or Wasm feature that was on by default in V8).
Related issues
See PR #27216 for context.